-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1966 - Fix sonarcloud critical and major issues (part 1) #1969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The javascript files inside the BPMN are legacy javascript files and they must be ES5 compliant so they should not be changed. Please revert these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned by @andrewsignori-aot , these files created as a part of a helper js in bpmn should not be changed. Please revert, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -81,7 +81,13 @@ export abstract class SFTPIntegrationBase<DownloadType> { | |||
|
|||
return filesToProcess | |||
.map((file) => path.join(remoteDownloadFolder, file.name)) | |||
.sort(); | |||
.sort((file1: string, file2: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be simplified and still be Sonarcloud compatible, IMO.
.map((file) => path.join(remoteDownloadFolder, file.name))
.sort((a, b) => a.localeCompare(b));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into Sonarcloud issues. Please take a look at the comments.
Is the last item in the description part of this PR? If not, please remove it. |
Thanks for taking care of Sonar code quality issues. Please revert the changes on workflow/*.js files as mentioned by other devs. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @sh16011993
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR addresses the following sonarcloud critical issues:
var
to useconst
orlet
.