#1966 - Fix sonarcloud critical and major issues (part 1) #1969
Conversation
sh16011993
requested review from
andrewsignori-aot,
andrepestana-aot,
ann-aot,
dheepak-aot,
hellolynn-tbtb,
guru-aot and
JasonCTang
There was a problem hiding this comment.
The javascript files inside the BPMN are legacy javascript files and they must be ES5 compliant so they should not be changed. Please revert these changes.
There was a problem hiding this comment.
As mentioned by @andrewsignori-aot , these files created as a part of a helper js in bpmn should not be changed. Please revert, thanks
There was a problem hiding this comment.
| @@ -81,7 +81,13 @@ export abstract class SFTPIntegrationBase<DownloadType> { | |||
|
|
|||
| return filesToProcess | |||
| .map((file) => path.join(remoteDownloadFolder, file.name)) | |||
| .sort(); | |||
| .sort((file1: string, file2: string) => { | |||
There was a problem hiding this comment.
It can be simplified and still be Sonarcloud compatible, IMO.
.map((file) => path.join(remoteDownloadFolder, file.name))
.sort((a, b) => a.localeCompare(b));
Is the last item in the description part of this PR? If not, please remove it. |
|
Thanks for taking care of Sonar code quality issues. Please revert the changes on workflow/*.js files as mentioned by other devs. |
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
This PR addresses the following sonarcloud critical issues:
varto useconstorlet.