Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1966 - Update user to nonroot user 1001 #1967

Merged
merged 1 commit into from
May 25, 2023
Merged

#1966 - Update user to nonroot user 1001 #1967

merged 1 commit into from
May 25, 2023

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented May 25, 2023 •
edited
Loading

In this PR, updated user to nonroot user 1001 for queue-consumer, api, workers and db-migration

@sh16011993 sh16011993 self-assigned this May 25, 2023
@sh16011993 sh16011993 added Sonar Involves fixing sonar related issues Camunda Workers Queue Consumers labels May 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sh16011993 sh16011993 added SIMS-Api SIMS-Api DB DB migration involved labels May 25, 2023
@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.66% ( 2053 / 11622 )
Methods: 7.84% ( 117 / 1492 )
Lines: 20.46% ( 1805 / 8820 )
Branches: 10% ( 131 / 1310 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 68.15% ( 383 / 562 )
Methods: 57.75% ( 41 / 71 )
Lines: 70.27% ( 338 / 481 )
Branches: 40% ( 4 / 10 )

@sh16011993 sh16011993 linked an issue May 25, 2023 that may be closed by this pull request
Fix Sonarcloud high security issues #1867
Closed
2 tasks
@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 40.97% ( 2851 / 6958 )
Methods: 34.11% ( 308 / 903 )
Lines: 46.31% ( 2406 / 5195 )
Branches: 15.93% ( 137 / 860 )

andrewsignori-aot
andrewsignori-aot approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrewsignori-aot andrewsignori-aot changed the title Update user to nonroot user 1001 #1966 - Update user to nonroot user 1001 May 25, 2023
ann-aot
ann-aot approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, USER 1001: this is a non-root user UID.
LGTM 👍

dheepak-aot
dheepak-aot approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

andrepestana-aot
andrepestana-aot approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sh16011993

@sh16011993 sh16011993 merged commit 6cb30c1 into main May 25, 2023
@sh16011993 sh16011993 deleted the 1867_change_user_to_nonroot_1001 branch May 25, 2023 21:28
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:28 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:29 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:29 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:29 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:29 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:29 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:36 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 25, 2023 21:38 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@hellolynn-tbtb hellolynn-tbtb Awaiting requested review from hellolynn-tbtb

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@sh16011993 sh16011993

Labels
Camunda Workers DB DB migration involved Queue Consumers SIMS-Api SIMS-Api Sonar Involves fixing sonar related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Sonarcloud high security issues
6 participants
@sh16011993 @dheepak-aot @andrewsignori-aot @guru-aot @ann-aot @andrepestana-aot