Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1791 - Enable Assessments tab view and NOA view for Public Institution Users - Part 3 #1952

Merged
merged 29 commits into from
May 29, 2023
Merged

#1791 - Enable Assessments tab view and NOA view for Public Institution Users - Part 3 #1952

merged 29 commits into from
May 29, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented May 19, 2023 •
edited
Loading

  1. Created E2E tests for, institution noa, award, history, request, appeal, and exception controllers.
    image
    image
    image
    image
    image
    image
  2. Tests for decorator @IsBCPublicInstitution() and @HasStudentDataAccess("studentId") are mostly the same in all tests.
  3. Application appeal DTOs were interchanged and updated the logic to use the correct DTO.
  4. Moved MASKED_MSFAA_NUMBER and StudentAssessmentStatus to libs.
  5. Created methods createFakeDisbursementReceiptValue and createFakeDisbursementReceipts.
  6. Restricted the staff section of the application exception on the API side for institution users.
  7. Confirmed with @JasonCTang about adding the confirmation of COE -> Institution doesn't need the feature to confirm the COE from the assessment page.

Next PR

  1. Offering change and scholastic change related changes and related e2e

@ann-aot ann-aot self-assigned this May 19, 2023
@ann-aot ann-aot changed the title initial commit #1791 - Enable Assessments tab view and NOA view for Public Institution Users - Part 3 May 19, 2023
@ann-aot ann-aot marked this pull request as ready for review May 26, 2023 18:43
@dheepak-aot
Copy link
Collaborator

Thanks for all the hard work put into this effort @ann-aot . Please have a look at the comments.

andrepestana-aot
andrepestana-aot reviewed May 26, 2023
View reviewed changes
...essment/_tests_/e2e/assessment.institutions.controller.getAssessmentAwardDetails.e2e-spec.ts Outdated
await db.disbursementReceiptValue.save(disbursementReceiptsValues);

const finalAwards = {};
finalAwards[`disbursementReceipt1Id`] = disbursementReceipt.id;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quotes

andrepestana-aot
andrepestana-aot approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just left minor comments.

dheepak-aot
dheepak-aot approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes @ann-aot . LGTM.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.69% ( 2060 / 11646 )
Methods: 7.9% ( 118 / 1493 )
Lines: 20.47% ( 1809 / 8836 )
Branches: 10.1% ( 133 / 1317 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 43.42% ( 3022 / 6960 )
Methods: 37.65% ( 340 / 903 )
Lines: 48.52% ( 2521 / 5196 )
Branches: 18.7% ( 161 / 861 )

@ann-aot ann-aot merged commit 99e1f66 into main May 29, 2023
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:34 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:35 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:35 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:35 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:35 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:35 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:44 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:46 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:46 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:46 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV May 29, 2023 15:46 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-#1791-part3 branch May 29, 2023 15:53
@ann-aot ann-aot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
E2E/Unit tests Institution Institution Features SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ann-aot @dheepak-aot @andrewsignori-aot @guru-aot @andrepestana-aot