-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1791 - Enable Assessments tab view and NOA view for Public Institution Users - Part 3 #1952
Conversation
...kend/apps/api/src/route-controllers/student-appeal/student-appeal.institutions.controller.ts
Show resolved
Hide resolved
Thanks for all the hard work put into this effort @ann-aot . Please have a look at the comments. |
...apps/api/src/route-controllers/application-exception/_tests_/application-exception-helper.ts
Outdated
Show resolved
Hide resolved
await db.disbursementReceiptValue.save(disbursementReceiptsValues); | ||
|
||
const finalAwards = {}; | ||
finalAwards[`disbursementReceipt1Id`] = disbursementReceipt.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just left minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes @ann-aot . LGTM.
Kudos, SonarCloud Quality Gate passed!
|
@IsBCPublicInstitution()
and@HasStudentDataAccess("studentId")
are mostly the same in all tests.MASKED_MSFAA_NUMBER
andStudentAssessmentStatus
to libs.createFakeDisbursementReceiptValue
andcreateFakeDisbursementReceipts
.Next PR