#1867 - Fix SonarCloud high security issues #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This image might run with root as the default user.
2 tasks
ann-aot
approved these changes
May 24, 2023
|
|
||
| # Building app | ||
| RUN npm run build queue-consumers | ||
|
|
||
| # Ensure that the non-root user will be able to write the coverage report. | ||
| RUN mkdir -p /app/apps/queue-consumers/coverage/ && chown node /app/apps/queue-consumers/coverage/ |
There was a problem hiding this comment.
Prod does not need it.
| COPY . . | ||
| # Copying sources. | ||
| COPY ./apps/queue-consumers ./apps/queue-consumers | ||
| COPY ./apps/db-migrations ./apps/db-migrations |
There was a problem hiding this comment.
Prod does not need it.
| COPY . . | ||
| # Copying sources. | ||
| COPY ./apps/workers ./apps/workers | ||
| COPY ./apps/db-migrations ./apps/db-migrations |
There was a problem hiding this comment.
Prod does not need it.
|
|
||
| # Building app | ||
| RUN npm run build workers | ||
|
|
||
| # Ensure that the non-root user will be able to write the coverage report. | ||
| RUN mkdir -p /app/apps/workers/coverage/ && chown node /app/apps/workers/coverage/ |
There was a problem hiding this comment.
Prod does not need it.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
May 24, 2023
dheepak-aot
approved these changes
May 25, 2023
guru-aot
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following issues fixed for api, queue-consumers and workers:
Issue: Running containers as a privileged user weakens their runtime security.
Fix: The images for api, workers and queue-consumers now run as a non-root user
Issue: Copying recursively might inadvertently add sensitive data to the container.
Fix: Only the required directories and files are now being copied.
The following issue is not fixed as a part of this PR:
Make sure write access is not granted to
otherusers.