Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1908 - E2E Tests - Workflow - Full-time Grants Eligibility #1949

Merged
merged 9 commits into from
May 24, 2023
Merged

#1908 - E2E Tests - Workflow - Full-time Grants Eligibility #1949

merged 9 commits into from
May 24, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented May 18, 2023 •
edited
Loading

  • E2E tests for full-time eligibility used on the BPMN workflow fulltime-assessment-*.
  • Fix for BGPD and SBSD that were not working for "BC Private" institutions.
  • There is a total of 112 tests executed for the eligibility part. Please take a look at the PR test execution to see the full test execution log.
  • There is one negative test for the "financial need is at least $1" that is not covered on these tests.
  • The tests are organized by the "grant" acronym.
  • A helper for students' dependents was created to allow an increase in the family size calculation.
  • The tests will be duplicated into the folder 2022-2023 in the next PR to avoid extra work on this one.

image

@andrewsignori-aot andrewsignori-aot added E2E/Unit tests Camunda Worflow Involves camunda workflow changes labels May 18, 2023
@andrewsignori-aot andrewsignori-aot self-assigned this May 18, 2023
@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review May 18, 2023 23:36
ann-aot
ann-aot reviewed May 19, 2023
View reviewed changes
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2023-2024.bpmn
@@ -1644,7 +1644,7 @@ or (calculatedDataPartnerFedralProvincialPDReceiptCost &gt; 0)</bpmn:conditionEx
<bpmn:intermediateThrowEvent id="Event_1ki3afc" name="awardEligibilitySBSD">
<bpmn:extensionElements>
<zeebe:ioMapping>
<zeebe:output source="=if institutionType = &#34;BC Public&#34; or &#34;BC Private&#34; then (&#10;if ((calculatedDataFederalAssessedNeed + calculatedDataProvincialAssessedNeed) &#62;= 1)&#10; and studentPDStatus = true&#10;then true &#10;else false&#10;)&#10;else&#10;false" target="awardEligibilitySBSD" />
<zeebe:output source="=if institutionType = &#34;BC Public&#34; or institutionType = &#34;BC Private&#34; then (&#10;if ((calculatedDataFederalAssessedNeed + calculatedDataProvincialAssessedNeed) &#62;= 1)&#10; and studentPDStatus = true&#10;then true &#10;else false&#10;)&#10;else&#10;false" target="awardEligibilitySBSD" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot reviewed May 19, 2023
View reviewed changes
...ackend/workflow/test/2022-2023/fulltime-assessment/fulltime-assessment-2022-2023.e2e-spec.ts
@@ -12,7 +12,7 @@ import {
} from "../../test-utils";
import { PROGRAM_YEAR } from "../constants/program-year.constants";

describe(`E2E Test Workflow fulltime-assessment-${PROGRAM_YEAR}`, () => {
describe(`E2E Test Workflow fulltime-assessment-${PROGRAM_YEAR}.`, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot reviewed May 19, 2023
View reviewed changes
sources/packages/backend/workflow/test/test-utils/execute-workflow-instance-utils.ts
* @param assessmentConsolidatedData assessment data.
* @returns result of the workflow execution.
*/
export async function executeFulltimeAssessmentForProgramYear(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the award. now we know the eligibility conditions 👍 Added some comments

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2047 / 11439 )
Methods: 7.93% ( 117 / 1475 )
Lines: 20.73% ( 1799 / 8678 )
Branches: 10.19% ( 131 / 1286 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 33.02% ( 177 / 536 )
Methods: 22.08% ( 17 / 77 )
Lines: 40.1% ( 158 / 394 )
Branches: 3.08% ( 2 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 68.32% ( 371 / 543 )
Methods: 57.97% ( 40 / 69 )
Lines: 70.47% ( 327 / 464 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 41.02% ( 2848 / 6943 )
Methods: 34.18% ( 308 / 901 )
Lines: 46.33% ( 2403 / 5187 )
Branches: 16.02% ( 137 / 855 )

ann-aot
ann-aot approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with FT grant eligibility. Thanks for doing the changes @andrewsignori-aot 👍

andrepestana-aot
andrepestana-aot approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

guru-aot
guru-aot reviewed May 24, 2023
View reviewed changes
sources/packages/backend/package.json
@@ -27,7 +27,7 @@
"test:e2e:workers": "npm run migration:run && cross-env ENVIRONMENT=test jest --collect-coverage --verbose --config ./apps/workers/test/jest-e2e.json --forceExit",
"test:e2e:workers:local": "cross-env ENVIRONMENT=test jest --collect-coverage --verbose --config ./apps/workers/test/jest-e2e.json --forceExit",
"test:e2e:workflow": "npm run deploy:camunda:definitions && cross-env ENVIRONMENT=test jest --verbose --config ./workflow/test/jest-e2e.json --forceExit",
"test:e2e:workflow:local": "cross-env ENVIRONMENT=test jest --verbose --config ./workflow/test/jest-e2e.json --forceExit",
"test:e2e:workflow:local": "cross-env ENVIRONMENT=test TZ=UTC jest --verbose --config ./workflow/test/jest-e2e.json --forceExit",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

guru-aot
guru-aot approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

@andrewsignori-aot andrewsignori-aot merged commit 3b85fd1 into main May 24, 2023
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 24, 2023 23:50 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot deleted the feature/#1908-full-time-eligibility-e2e branch May 24, 2023 23:50
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 24, 2023 23:51 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 24, 2023 23:51 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 24, 2023 23:51 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 24, 2023 23:51 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 24, 2023 23:51 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 25, 2023 00:09 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 25, 2023 00:11 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 25, 2023 00:11 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 25, 2023 00:11 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 25, 2023 00:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@dheepak-aot dheepak-aot Awaiting requested review from dheepak-aot

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Camunda Worflow Involves camunda workflow changes E2E/Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewsignori-aot @guru-aot @ann-aot @andrepestana-aot