#1723 - E2E/Units Tests - Review Workers E2E Tests

[andrepestana-aot]

• Added a createTestingAppModule for Workers E2E tests;
• Moved disbursement.controller.saveDisbursementSchedules.e2e-spec to e2e folder;
• Create the following tests:

  • apps/workers/src/controllers/program-info-request/tests/e2e/program-info-request.controller-updateApplicationStatus.e2e-spec.ts
    ProgramInfoRequestController(e2e)-updateApplicationStatus
    ✓ Should update application PIR status when not set. (67 ms)
    ✓ Should not update application PIR status when already set. (22 ms)
    ✓ Should have job error status when could not find the application. (2 ms)

  • apps/workers/src/controllers/supporting-user/test/e2e/supporting-user.controller.createSupportingUsers.e2e-spec.ts
    SupportingUserController(e2e)-createSupportingUsers
    ✓ Should create parent supporting users when requested. (87 ms)
    ✓ Should create partner supporting user when requested. (39 ms)
    ✓ Should not create supporting users when application already has one. (45 ms)

  • apps/workers/src/controllers/application/tests/e2e/application.controller-updateStatus.e2e-spec.ts
    ApplicationController(e2e)-updateStatus
    ✓ Should update application status when it receives the correct original status. (80 ms)
    ✓ Should not update application status and return error when it does not receive the correct original status. (35 ms)
    ✓ Should return error when it does not find the application. (2 ms)

  • apps/workers/src/controllers/application/tests/e2e/application.controller-verifyApplicationExceptions.e2e-spec.ts
    ApplicationController(e2e)-verifyApplicationExceptions
    ✓ Should create and associate application exceptions when there are some exceptions for the application. (57 ms)
    ✓ Should not create any application exception when there is no application exception in application data. (13 ms)
    ✓ Should return error when it does not find the application. (3 ms)

  • apps/workers/test/app.e2e-spec.ts
    WorkersController (e2e)
    ✓ Should be able to initialize workers module (564 ms)

[andrewsignori-aot]

Maybe not part of the PR since the main goal was to start the E2E for workers but the scenario where "The exceptions were already processed for this application." is important to ensure the idempotency of the process.
We can add it to this PR os create a new ticket to capture the next ones.

[andrepestana-aot]

I created a test for this case: "Should not create an application exception when there is already one for the application."

[andrewsignori-aot]

Really great simplification. This one serves as an example of how the use of the E2EDataSources can make the E2E code cleaner 😉

[ann-aot]

some minor comments added

[andrewsignori-aot]

Thanks for doing the changes. Please take a look at the last minor comments.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	17.67% ( 2052 / 11616 )
Methods:	7.85% ( 117 / 1491 )
Lines:	20.46% ( 1804 / 8816 )
Branches:	10.01% ( 131 / 1309 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	68.15% ( 383 / 562 )
Methods:	57.75% ( 41 / 71 )
Lines:	70.27% ( 338 / 481 )
Branches:	40% ( 4 / 10 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	49.81% ( 267 / 536 )
Methods:	41.56% ( 32 / 77 )
Lines:	55.33% ( 218 / 394 )
Branches:	26.15% ( 17 / 65 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	40.97% ( 2851 / 6958 )
Methods:	34.11% ( 308 / 903 )
Lines:	46.31% ( 2406 / 5195 )
Branches:	15.93% ( 137 / 860 )

[ann-aot]

Thanks for doing the changes 👍 Good work @andrepestana-aot

[sh16011993]

LGTM 👍

[andrewsignori-aot]

Thanks for doing the changes, looks good 👍