#1759 - Reissue MSFAA - Part 2 - NOA UI Changes #1936

andrewsignori-aot · 2023-05-11T23:21:04Z

Enabled the visualization of the MSFAAs in the NOA with additional signed/cancellation messages and the "Reissue MSFAA" button for the Ministry in case there is a canceled MSFAA associated with pending disbursement.
Added MSFAACancelledDate and MSFAADateSigned to the API return following the approach in place. Renamed the COE status previously named Status to COEStatus since the object itself is related to the disbursement and now we have a status for it.
The form.io components are duplicated to deal with one MSFAA or two MSFAA scenarios. If anyone has a better idea please let's talk about it. The current approach, even with some duplication at the form.io definition level is still easy to follow.
The canReissueMSFAA logic to display the button uses the props.canReissueMSFAA and it loses the reactivity in the way that it is right now. I did not find it too important to keep the reactivity for this case.

Two disbursements, same MSFAA, MSFAA signed.

Two disbursements, same MSFAA, MSFAA not signed.

Two disbursements (at least one is pending), same MSFAA, MSFAA canceled.

Two disbursements (first is sent, second is pending), different MSFAA, second MSFAA waiting to be signed.

Two disbursements (first is sent, second is pending), different MSFAA, both are canceled on different dates.

Student view

Reissue MSFAA confirmation modal.

hellolynn-tbtb · 2023-05-12T16:35:01Z

Nice work! @andrewsignori-aot Just missing a few things. No problem if you do it in the next PR!

andrepestana-aot · 2023-05-12T23:10:05Z

sources/packages/web/src/views/aest/NoticeOfAssessment.vue

+      :assessmentId="assessmentId"
+      :can-reissue-m-s-f-a-a="true"
+      @reissue-m-s-f-a-a="reissueMSFAA"


Not a problem, just curious: should we use kebab case for the attributes too? If that's case assessmentId should be assessment-id 😄

Good question. I did not do that manually 😄, that was the VS Code suggestion while auto-completing.
We have been doing it for the component's name (e.g. notice-of-assessment-form-view) because it looks like more HTML style (IMO). For instance when we declare data custom attributes we will use data-*.
Should we change assessmentId to assessment-id? Yes, but we do not need to go back and do it all over the place. Does it make sense?
@ann-aot @guru-aot @dheepak-aot @sh16011993

yes 😄 we can do it and make sense

sources/packages/web/src/views/aest/NoticeOfAssessment.vue

sources/packages/web/src/components/common/modals/ConfirmModal.vue

andrepestana-aot

Great job. I left some comments.

ann-aot · 2023-05-12T23:28:56Z

sources/packages/web/src/components/generic/FooterButtons.vue

@@ -19,15 +19,9 @@
        data-cy="primaryFooterButton"
        color="primary"
        @click="$emit('primaryClick')"
+        :loading="processing"


sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

ann-aot · 2023-05-12T23:41:51Z

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

+    reissueMSFAA: (
+      applicationId: number,
+      loadNOA: () => Promise<void>,
+      processing: (processing: boolean) => void,


This approach is also good

andrewsignori-aot · 2023-05-15T18:08:51Z

Nice work! @andrewsignori-aot Just missing a few things. No problem if you do it in the next PR!

UI adjusted as below @hellolynn-tbtb

sources/packages/backend/libs/services/src/msfaa-number/msfaa-number-shared.service.ts

guru-aot · 2023-05-15T18:14:52Z

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

+        ...assessment,
+        canReissueMSFAA,
+      };
+      console.log(assessment);


why we need a console.log here?

It was a leftover from before. It is removed already.

guru-aot

LGTM, nice work @andrewsignori-aot

sources/packages/forms/src/form-definitions/noticeofassessment.json

dheepak-aot · 2023-05-15T19:02:33Z

.../packages/backend/apps/api/src/route-controllers/assessment/assessment.controller.service.ts

        schedule.coeStatus;
      disbursementDetails[`${disbursementIdentifier}MSFAANumber`] =
        schedule.msfaaNumber.msfaaNumber;
+      disbursementDetails[`${disbursementIdentifier}MSFAACancelledDate`] =
+        schedule.msfaaNumber.cancelledDate;
+      disbursementDetails[`${disbursementIdentifier}MSFAADateSigned`] =


Why do we send the date signed in API?, I couldn't see that in UI either in figma or screenshots.

The signed date received from the API is used by the method getMSFAAStatus.

ann-aot · 2023-05-15T19:03:04Z

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

+    /**
+     * Defines the MSFAA status based on the signed date and cancelled dates.
+     * @param signedDate signed date.
+     * @param cancelledDate cancelled date.


return comment

ann-aot · 2023-05-15T19:03:09Z

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

+    const getMSFAAStatus = (
+      signedDate?: Date,
+      cancelledDate?: Date,
+    ): MSFAAStatus => {


return comment

ann-aot · 2023-05-15T19:03:26Z

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

+     * Defines the icon class to displayed depending on the MSFAA status.
+     * @param msfaaStatus MSFAA status.
+     */
+    const getMSFAAStatusClass = (msfaaStatus: MSFAAStatus): string => {


return comment

ann-aot

LGTM 👍 added some minor comments

sources/packages/backend/libs/services/src/msfaa-number/msfaa-number-shared.service.ts

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue

dheepak-aot · 2023-05-15T19:47:47Z

sources/packages/web/src/views/aest/NoticeOfAssessment.vue

+        await ApplicationService.shared.reissueMSFAA(applicationId);
+        snackBar.success("MSFAA was reissued successfully.");
+        await reloadNOA();
+      } catch (error: unknown) {


do we need error in the catch?

Nope, removing it.

dheepak-aot · 2023-05-15T19:52:29Z

Good to see the MSFAA and Re-Issue MSFAA happening. Added few comments.

sonarqubecloud · 2023-05-15T20:00:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-05-15T20:03:57Z

Backend Unit Tests Coverage Report

Totals
Statements:	18.11% ( 2040 / 11266 )
Methods:	8.19% ( 119 / 1453 )
Lines:	20.94% ( 1792 / 8557 )
Branches:	10.27% ( 129 / 1256 )

github-actions · 2023-05-15T20:04:36Z

E2E Workflow Workers Coverage Report

Totals
Statements:	33.02% ( 177 / 536 )
Methods:	22.08% ( 17 / 77 )
Lines:	40.1% ( 158 / 394 )
Branches:	3.08% ( 2 / 65 )

github-actions · 2023-05-15T20:04:53Z

E2E Queue Consumers Coverage Report

Totals
Statements:	68.32% ( 371 / 543 )
Methods:	57.97% ( 40 / 69 )
Lines:	70.47% ( 327 / 464 )
Branches:	40% ( 4 / 10 )

dheepak-aot

Thanks for making the changes. LGTM 👍

github-actions · 2023-05-15T20:07:02Z

E2E SIMS API Coverage Report

Totals
Statements:	41.54% ( 2918 / 7025 )
Methods:	34.76% ( 317 / 912 )
Lines:	46.8% ( 2455 / 5246 )
Branches:	16.84% ( 146 / 867 )

ann-aot

Thanks for doing the changes 👍 Good work @andrewsignori-aot

andrepestana-aot

Thanks for the answers.

andrewsignori-aot added 4 commits May 9, 2023 19:57

Adjusting NOA UI

ff2c0d8

Merge branch 'main' into feature/#1759-msfaa-reissue-noa-ui

caeb181

Adjusted NOA UI and added Reissue button.

ccdb043

Reissue UI calling API

4b8c44e

andrewsignori-aot self-assigned this May 12, 2023

andrewsignori-aot added Web Portal SIMS-Api SIMS-Api labels May 12, 2023

Form.io definition

dd183d9

andrewsignori-aot requested review from ann-aot, andrepestana-aot, sh16011993, dheepak-aot, guru-aot, hellolynn-tbtb and JasonCTang May 12, 2023 01:20

andrewsignori-aot marked this pull request as ready for review May 12, 2023 01:21

andrepestana-aot reviewed May 12, 2023

View reviewed changes

sources/packages/web/src/views/aest/NoticeOfAssessment.vue Show resolved Hide resolved

andrepestana-aot reviewed May 12, 2023

View reviewed changes

sources/packages/web/src/components/common/modals/ConfirmModal.vue Outdated Show resolved Hide resolved

andrepestana-aot reviewed May 12, 2023

View reviewed changes

ann-aot reviewed May 12, 2023

View reviewed changes

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue Outdated Show resolved Hide resolved

ann-aot reviewed May 12, 2023

View reviewed changes

Added status to MSFAA on Vue

e195902

Form.io UI adjustments

538e2a3

guru-aot reviewed May 15, 2023

View reviewed changes

sources/packages/backend/libs/services/src/msfaa-number/msfaa-number-shared.service.ts Outdated Show resolved Hide resolved

guru-aot reviewed May 15, 2023

View reviewed changes

PR review comments.

b1fa042

guru-aot approved these changes May 15, 2023

View reviewed changes

ann-aot reviewed May 15, 2023

View reviewed changes

sources/packages/forms/src/form-definitions/noticeofassessment.json Outdated Show resolved Hide resolved

dheepak-aot reviewed May 15, 2023

View reviewed changes

ann-aot reviewed May 15, 2023

View reviewed changes

dheepak-aot reviewed May 15, 2023

View reviewed changes

sources/packages/backend/libs/services/src/msfaa-number/msfaa-number-shared.service.ts Show resolved Hide resolved

dheepak-aot reviewed May 15, 2023

View reviewed changes

sources/packages/web/src/components/common/NoticeOfAssessmentFormView.vue Show resolved Hide resolved

PR comments.

1f3c4cb

dheepak-aot reviewed May 15, 2023

View reviewed changes

PR comments

a1e929d

dheepak-aot approved these changes May 15, 2023

View reviewed changes

ann-aot approved these changes May 15, 2023

View reviewed changes

andrepestana-aot approved these changes May 15, 2023

View reviewed changes

andrewsignori-aot merged commit 6e3c85f into main May 15, 2023

andrewsignori-aot temporarily deployed to DEV May 15, 2023 20:50 — with GitHub Actions Inactive

andrewsignori-aot deleted the feature/#1759-msfaa-reissue-noa-ui branch May 15, 2023 20:50

andrewsignori-aot temporarily deployed to DEV May 15, 2023 20:50 — with GitHub Actions Inactive

andrewsignori-aot temporarily deployed to DEV May 15, 2023 21:07 — with GitHub Actions Inactive

This was referenced Dec 4, 2023

Interface for reissue MSFAA button for Ministry Staff #1782

Closed

Updating NOA to handle new MSFAA being issued. #1781

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1759 - Reissue MSFAA - Part 2 - NOA UI Changes #1936

#1759 - Reissue MSFAA - Part 2 - NOA UI Changes #1936

andrewsignori-aot commented May 11, 2023 •

edited

Loading

hellolynn-tbtb commented May 12, 2023

andrepestana-aot May 12, 2023

andrewsignori-aot May 15, 2023

ann-aot May 15, 2023

andrepestana-aot left a comment

ann-aot May 12, 2023

ann-aot May 12, 2023

andrewsignori-aot commented May 15, 2023

guru-aot May 15, 2023

andrewsignori-aot May 15, 2023

guru-aot left a comment

dheepak-aot May 15, 2023

andrewsignori-aot May 15, 2023

ann-aot May 15, 2023

andrewsignori-aot May 15, 2023

ann-aot May 15, 2023

andrewsignori-aot May 15, 2023

ann-aot May 15, 2023

andrewsignori-aot May 15, 2023

ann-aot left a comment

dheepak-aot May 15, 2023

andrewsignori-aot May 15, 2023

andrewsignori-aot May 15, 2023

dheepak-aot commented May 15, 2023

sonarqubecloud bot commented May 15, 2023

github-actions bot commented May 15, 2023

github-actions bot commented May 15, 2023

github-actions bot commented May 15, 2023

dheepak-aot left a comment

github-actions bot commented May 15, 2023

ann-aot left a comment

andrepestana-aot left a comment

#1759 - Reissue MSFAA - Part 2 - NOA UI Changes #1936

#1759 - Reissue MSFAA - Part 2 - NOA UI Changes #1936

Conversation

andrewsignori-aot commented May 11, 2023 • edited Loading

Two disbursements, same MSFAA, MSFAA signed.

Two disbursements, same MSFAA, MSFAA not signed.

Two disbursements (at least one is pending), same MSFAA, MSFAA canceled.

Two disbursements (first is sent, second is pending), different MSFAA, second MSFAA waiting to be signed.

Two disbursements (first is sent, second is pending), different MSFAA, both are canceled on different dates.

Student view

Reissue MSFAA confirmation modal.

hellolynn-tbtb commented May 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrepestana-aot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsignori-aot commented May 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guru-aot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ann-aot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheepak-aot commented May 15, 2023

sonarqubecloud bot commented May 15, 2023

github-actions bot commented May 15, 2023

Backend Unit Tests Coverage Report

github-actions bot commented May 15, 2023

E2E Workflow Workers Coverage Report

github-actions bot commented May 15, 2023

E2E Queue Consumers Coverage Report

dheepak-aot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 15, 2023

E2E SIMS API Coverage Report

ann-aot left a comment

Choose a reason for hiding this comment

andrepestana-aot left a comment

Choose a reason for hiding this comment

andrewsignori-aot commented May 11, 2023 •

edited

Loading