#1853 - Enable Notes Tab for Public Institution User #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepestana-aot
requested review from
sh16011993,
ann-aot,
dheepak-aot,
hellolynn-tbtb,
andrewsignori-aot,
JasonCTang and
guru-aot
andrepestana-aot
added
User Story
Institution
ann-aot
reviewed
May 10, 2023
sources/packages/backend/apps/api/src/route-controllers/note/note.institutions.controller.ts
Show resolved
Hide resolved
ann-aot
reviewed
May 10, 2023
sources/packages/backend/apps/api/src/route-controllers/note/note.institutions.controller.ts
Show resolved
Hide resolved
ann-aot
reviewed
May 10, 2023
| * @param relations entity relations. | ||
| * @returns a persisted fake student restriction. | ||
| */ | ||
| export async function saveFakeStudentRestriction( |
There was a problem hiding this comment.
@sh16011993 also created saveFakeStudentRestriction method, probably we can have one
https://github.com/bcgov/SIMS/pull/1924/files
ann-aot
reviewed
May 10, 2023
sources/packages/web/src/components/common/notes/StudentNotes.vue
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
May 10, 2023
sources/packages/backend/apps/api/src/route-controllers/note/note.institutions.controller.ts
Show resolved
Hide resolved
ann-aot
reviewed
May 10, 2023
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Show resolved
Hide resolved
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
May 10, 2023
sources/packages/web/src/views/institution/student/InstitutionStudentNotes.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
May 10, 2023
sources/packages/web/src/components/common/notes/StudentNotes.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
May 10, 2023
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
May 10, 2023
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
May 10, 2023
.../route-controllers/note/_tests_/e2e/note.institutions.controller.getStudentNotes.e2e-spec.ts
Show resolved
Hide resolved
|
Good to see the student notes for institution. Please have a look at the comments. |
dheepak-aot
reviewed
May 12, 2023
| .expect({ | ||
| statusCode: 403, | ||
| message: | ||
| "The institution is not allowed access to the student data of the given student.", |
There was a problem hiding this comment.
THis error is in a constant INSTITUTION_STUDENT_DATA_ACCESS_ERROR_MESSAGE
dheepak-aot
approved these changes
May 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
May 12, 2023
ann-aot
approved these changes
May 12, 2023
andrewsignori-aot
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ministry view:
Institutions view:
Added test cases:
√ Should get all note types for a student when they are available.
√ Should throw Forbidden when student does not exist.
√ Should throw Forbidden when student exists but does not have an application for the institution.
√ Should cause a bad request when a wrong note type is provided as a filter.
√ Should get an empty student notes result when student has no notes.
√ Should get specific student notes types when student has notes and a note type filter was provided.
√ Should not get notes for student restriction and resolution notes with notification type 'no effect' when any are available.