Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1866 - Bug fix for issue when accessing some locationIds from Institutions portal #1930

Merged
merged 1 commit into from
May 8, 2023
Merged

#1866 - Bug fix for issue when accessing some locationIds from Institutions portal #1930

merged 1 commit into from
May 8, 2023

Conversation

andrepestana-aot
Copy link
Collaborator

  • replaced getting the first item by using route.params.locationId as string.

@andrepestana-aot andrepestana-aot self-assigned this May 8, 2023
@andrepestana-aot andrepestana-aot added the Bug Something isn't working label May 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented May 8, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

github-actions bot commented May 8, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.12% ( 2010 / 11091 )
Methods: 8.3% ( 119 / 1434 )
Lines: 20.91% ( 1762 / 8427 )
Branches: 10.49% ( 129 / 1230 )

@github-actions
Copy link

github-actions bot commented May 8, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 68.32% ( 371 / 543 )
Methods: 57.97% ( 40 / 69 )
Lines: 70.47% ( 327 / 464 )
Branches: 40% ( 4 / 10 )

ann-aot
ann-aot approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @andrepestana-aot for fixing the issue.

@github-actions
Copy link

github-actions bot commented May 8, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 40.33% ( 2764 / 6854 )
Methods: 33.45% ( 298 / 891 )
Lines: 45.62% ( 2333 / 5114 )
Branches: 15.67% ( 133 / 849 )

andrewsignori-aot
andrewsignori-aot approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrepestana-aot andrepestana-aot merged commit 9b64d93 into main May 8, 2023
@andrepestana-aot andrepestana-aot deleted the bug_after_1866 branch May 8, 2023 23:13
@andrepestana-aot andrepestana-aot temporarily deployed to DEV May 8, 2023 23:13 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV May 8, 2023 23:13 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV May 8, 2023 23:24 — with GitHub Actions Inactive
dheepak-aot
dheepak-aot reviewed May 8, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsignori-aot andrewsignori-aot changed the title 1866 - Bug fix for issue when accessing some locationIds from Institutions portal #1866 - Bug fix for issue when accessing some locationIds from Institutions portal May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot left review comments

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@guru-aot guru-aot Awaiting requested review from guru-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrepestana-aot andrepestana-aot

Labels
Ad-hoc Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrepestana-aot @dheepak-aot @andrewsignori-aot @ann-aot @JasonCTang