Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1864 - Country Code Conversion for Part-time e-Cert #1921

Merged
merged 5 commits into from
May 3, 2023
Merged

#1864 - Country Code Conversion for Part-time e-Cert #1921

merged 5 commits into from
May 3, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented May 3, 2023 •
edited
Loading

  • Changing part-time e-Cert generation to use country code as CAN when Canada.
  • Fix for a missing await for updateRecordsInSentFile as pointed out by Sonarcloud and pointed out by @dheepak-aot.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review May 3, 2023 17:50
@andrewsignori-aot andrewsignori-aot self-assigned this May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.17% ( 2015 / 11090 )
Methods: 8.37% ( 120 / 1434 )
Lines: 20.92% ( 1763 / 8426 )
Branches: 10.73% ( 132 / 1230 )

@github-actions
Copy link

github-actions bot commented May 3, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

github-actions bot commented May 3, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 68.32% ( 371 / 543 )
Methods: 57.97% ( 40 / 69 )
Lines: 70.47% ( 327 / 464 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented May 3, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 40.02% ( 2736 / 6836 )
Methods: 32.96% ( 293 / 889 )
Lines: 45.31% ( 2310 / 5098 )
Branches: 15.67% ( 133 / 849 )

dheepak-aot
dheepak-aot approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it. 👍

guru-aot
guru-aot approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

ann-aot
ann-aot approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsignori-aot andrewsignori-aot merged commit 1a3581f into main May 3, 2023
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 3, 2023 20:15 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot deleted the feature/#1864-country-code-conversion branch May 3, 2023 20:15
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 3, 2023 20:16 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV May 3, 2023 20:30 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann-aot ann-aot ann-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

@sh16011993 sh16011993 Awaiting requested review from sh16011993

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Queue Consumers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewsignori-aot @dheepak-aot @guru-aot @ann-aot