#1864 - MSFAA Receive File E2E Test Automation #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsignori-aot
requested review from
guru-aot,
sh16011993,
dheepak-aot,
ann-aot,
andrepestana-aot and
JasonCTang
ann-aot
reviewed
May 2, 2023
| { dateSigned: IsNull() }, | ||
| { dateSigned: getISODateOnlyString(new Date()) }, | ||
| ); | ||
| // Cancel any pending MSFAA. |
There was a problem hiding this comment.
mm...here what does it mean "pending MSFAA"? when dateSigned === null then MSFAA is pending, right?
| }, | ||
| }); | ||
| expect(msfaaUpdatedRecords).toHaveLength(msfaaInputData.length); | ||
| const [fistSignedMSFAA, cancelledMSFAA, secondSignedMSFAA] = |
There was a problem hiding this comment.
Minor: the name of the variable should be "firstSignedMSFAA".
ann-aot
reviewed
May 2, 2023
...msfaa-integration/_tests_/msfaa-part-time-process-response-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
andrepestana-aot
approved these changes
May 2, 2023
ann-aot
approved these changes
May 2, 2023
dheepak-aot
reviewed
May 2, 2023
| @@ -76,7 +83,7 @@ export class MSFAAResponseProcessingService { | |||
| try { | |||
| await this.processCancelledRecord(cancelledRecord); | |||
| result.processSummary.push( | |||
| `Status cancelled record from line ${cancelledRecord.lineNumber}.`, | |||
| `Record from line ${cancelledRecord.lineNumber}, updated as canceled.`, | |||
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mockDownloadFilesto allow the simulation of a file downloaded from SFTP.The file will be available on the disk and the SSH client methods
listandgetwill be mocked to allow the SSH methods to be invoked as usual but returning the mocked file instead.getStructuredRecordsandcreateFileFromStructuredRecordsto allow the file content manipulation before the mocked file content is downloaded.E2E tests
√ Should process an MSFAA response with confirmations and a cancellation and update all records when the file is received as expected. (280 ms)
√ Should successfully process 2 MSFAA records when a file has 3 records but one throws an error during DB update. (212 ms)
√ Should throw an error when the MSFAA file contains an invalid SIN hash total. (14 ms)
√ Should throw an error when the MSFAA file contains an invalid record count. (7 ms)
√ Should throw an error when the MSFAA file contains an invalid header code. (9 ms)
√ Should throw an error when the MSFAA file contains an invalid footer code. (9 ms)