#1830 - Test case fix #1912
Merged
#1830 - Test case fix #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
commented
Apr 28, 2023
| @@ -88,27 +88,6 @@ describe("StudentInstitutionsController(e2e)-getStudentProfile", () => { | |||
| sin: student.sinValidation.sin, | |||
| }); | |||
| }); | |||
| // TODO: When the authorization is implemented for institution student search, | |||
There was a problem hiding this comment.
This is not a valid test scenario anymore.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
requested review from
andrepestana-aot,
andrewsignori-aot,
guru-aot and
ann-aot
ann-aot
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the test case failure by having the right institution in place and removing the test cases which are not valid anymore with decorators in place.