Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1761 - Handling full time BCSL lifetime and federal maximums - fix #1909

Merged
merged 2 commits into from
Apr 27, 2023
Merged

#1761 - Handling full time BCSL lifetime and federal maximums - fix #1909

merged 2 commits into from
Apr 27, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Apr 26, 2023

  • totalDisbursedBCSLAmount was calculating valueAmount sum instead of effectiveAmount., which was causing the issue

@ann-aot ann-aot self-assigned this Apr 26, 2023
@ann-aot ann-aot added the SIMS-Api SIMS-Api label Apr 26, 2023
dheepak-aot
dheepak-aot approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewsignori-aot
andrewsignori-aot approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 1969 / 11009 )
Methods: 8.06% ( 115 / 1427 )
Lines: 20.61% ( 1725 / 8368 )
Branches: 10.63% ( 129 / 1214 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 65.01% ( 353 / 543 )
Methods: 53.62% ( 37 / 69 )
Lines: 67.24% ( 312 / 464 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 39.13% ( 2651 / 6775 )
Methods: 31.56% ( 278 / 881 )
Lines: 44.53% ( 2248 / 5048 )
Branches: 14.78% ( 125 / 846 )

@ann-aot ann-aot merged commit e4e12ae into main Apr 27, 2023
@ann-aot ann-aot temporarily deployed to DEV April 27, 2023 23:42 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV April 27, 2023 23:48 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV April 28, 2023 00:02 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the fix/lifeTimeMax branch April 28, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ann-aot @dheepak-aot @andrewsignori-aot @guru-aot