Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1761 - Handling full time BCSL lifetime and federal maximums - UI refator #1901

Merged
merged 1 commit into from
Apr 21, 2023
Merged

#1761 - Handling full time BCSL lifetime and federal maximums - UI refator #1901

merged 1 commit into from
Apr 21, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Apr 21, 2023

  • Created a PR to move the restrictions code to the intended group
    image

@ann-aot ann-aot self-assigned this Apr 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.93% ( 1968 / 10975 )
Methods: 8.08% ( 115 / 1424 )
Lines: 20.65% ( 1724 / 8350 )
Branches: 10.74% ( 129 / 1201 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 65.01% ( 353 / 543 )
Methods: 53.62% ( 37 / 69 )
Lines: 67.24% ( 312 / 464 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 38.94% ( 2634 / 6765 )
Methods: 30.91% ( 272 / 880 )
Lines: 44.4% ( 2240 / 5045 )
Branches: 14.52% ( 122 / 840 )

guru-aot
guru-aot approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely work @ann-aot

dheepak-aot
dheepak-aot approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

andrewsignori-aot
andrewsignori-aot approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ann-aot ann-aot merged commit db0abba into main Apr 21, 2023
@ann-aot ann-aot temporarily deployed to DEV April 21, 2023 23:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV April 21, 2023 23:08 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV April 21, 2023 23:18 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-#1761/part-3-ui branch April 24, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@hellolynn-tbtb hellolynn-tbtb Awaiting requested review from hellolynn-tbtb

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ann-aot @dheepak-aot @andrewsignori-aot @guru-aot