#582 - Restrict non BC Public Institutions from accessing Routes for BC Public institutions #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BC Public Institutions
dheepak-aot
requested review from
andrewsignori-aot,
andrepestana-aot,
sh16011993,
guru-aot,
ann-aot and
JasonCTang
ann-aot
reviewed
Apr 20, 2023
| @@ -468,6 +469,7 @@ export const institutionRoutes: Array<RouteRecordRaw> = [ | |||
| component: InstitutionStudentProfile, | |||
| meta: { | |||
| clientType: ClientIdType.Institution, | |||
| allowOnlyBCPublic: true, | |||
There was a problem hiding this comment.
just wanted to check if, adding allowOnlyBCPublic to the parent (line 457) will it protect all its children. As discussed, you can just try and check
There was a problem hiding this comment.
I tested by using allowOnlyBCPublic in parent onluy and it works perfectly. thanks.
There was a problem hiding this comment.
Thanks for trying it. As discussed, we can test and remove the other meta from the children in another ticket
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
Apr 20, 2023
ann-aot
approved these changes
Apr 20, 2023
andrewsignori-aot
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the route meta property
allowOnlyBCPublicblock access for non BC Public Institution users from accessing routes which are for BCPublic institutions.