#1851 - Enable File Upload for Public Institution User #1893

sh16011993 · 2023-04-19T07:57:27Z

The following tasks were completed as a part of this task:

Remove upload file button for Public Institution User.
Disable links to download/view the file for Public Institution User.
Wrote E2E test - This included writing test for inserting fake file upload data into the database and retrieving it using the API endpoint and validating the retrieved data with the inserted data.

Screenshot showing the removed upload file button and disabled links to download/view the file:

- Remove upload file button. - Disable links to download/view the file. - Wrote E2E tests.

sources/packages/backend/libs/test-utils/src/factories/student-file-uploads.ts

...ollers/student/_tests_/e2e/student.institutions.controller.getStudentFileUploads.e2e-spec.ts

sources/packages/backend/apps/api/src/route-controllers/student/models/student.dto.ts

...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts

sources/packages/web/src/components/common/students/StudentFileUploads.vue

...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts

dheepak-aot · 2023-04-19T16:22:47Z

sources/packages/web/src/components/common/students/StudentFileUploads.vue

@@ -0,0 +1,206 @@
+<template>
+  <tab-container>


👍 thanks for moving it to components.

sources/packages/web/src/components/common/students/StudentFileUploads.vue

dheepak-aot · 2023-04-19T16:30:18Z

sources/packages/web/src/services/StudentService.ts

+   * Get all student documents for Institution user.
+   * @return list of student documents.
+   */
+  async getInstitutionStudentFiles(


As per https://github.com/bcgov/SIMS/pull/1893/files#r1171588207 we can avoid creating a new method.

https://github.com/bcgov/SIMS/pull/1893/files#r1171726717

sources/packages/web/src/components/common/students/StudentFileUploads.vue

sources/packages/web/src/services/http/StudentApi.ts

sources/packages/web/src/services/http/dto/Student.dto.ts

...ollers/student/_tests_/e2e/student.institutions.controller.getStudentFileUploads.e2e-spec.ts

dheepak-aot · 2023-04-21T19:03:21Z

Thanks for making the changes. Added more comments.

…dal to the common component

sources/packages/backend/apps/api/src/route-controllers/student/student.controller.service.ts

sources/packages/web/src/components/common/students/StudentFileUploads.vue

sources/packages/web/src/views/aest/student/FileUploads.vue

andrewsignori-aot

Please take a look at a few minor comments. I believe that the below one is the one that requires more attention #1893 (comment)

dheepak-aot · 2023-04-24T19:35:48Z

sources/packages/web/src/components/common/students/StudentFileUploads.vue

+    };
+
+    const uploadFile = () => {
+      context.emit("uploadFile", fileUploadModal, () =>


I didn't follow why are we emitting back to parent here?

I technically what happen between here and parent and feel here that coupling is tight, but are we going to follow this approach moving forward?

I have updated this part of the code as suggested by @andrewsignori-aot

Instead of passing the entire fileUploadModal as argument, only associatedFiles array is being passed to the emitted event handler. We are emitting uploadFile to the AEST specific file upload component to allow for the API call saveAESTUploadedFilesToStudent to be made by the consumer since it is a consumer specific operation.

@dheepak-aot considering also the last explanation given by @sh16011993 is there anything here to be considered as a new approach?
If the point was about the modal as a parameter, that was exactly what I asked to be changed but besides that, is there anything else?

No I am good.

sonarqubecloud · 2023-04-24T21:41:07Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-04-24T21:41:20Z

Backend Unit Tests Coverage Report

Totals
Statements:	17.89% ( 1969 / 11009 )
Methods:	8.06% ( 115 / 1427 )
Lines:	20.61% ( 1725 / 8368 )
Branches:	10.63% ( 129 / 1214 )

github-actions · 2023-04-24T21:42:16Z

E2E Workflow Workers Coverage Report

Totals
Statements:	32.41% ( 176 / 543 )
Methods:	21.25% ( 17 / 80 )
Lines:	39.25% ( 157 / 400 )
Branches:	3.17% ( 2 / 63 )

github-actions · 2023-04-24T21:43:07Z

E2E Queue Consumers Coverage Report

Totals
Statements:	65.01% ( 353 / 543 )
Methods:	53.62% ( 37 / 69 )
Lines:	67.24% ( 312 / 464 )
Branches:	40% ( 4 / 10 )

ann-aot

Good work @sh16011993 👍 Thanks for doing the changes

ann-aot

Pls take a look at the failing test cases

github-actions · 2023-04-25T01:57:31Z

E2E SIMS API Coverage Report

Totals
Statements:	39.07% ( 2647 / 6775 )
Methods:	31.33% ( 276 / 881 )
Lines:	44.49% ( 2246 / 5048 )
Branches:	14.78% ( 125 / 846 )

andrewsignori-aot

Thanks for doing the changes, looks good 👍

dheepak-aot

LGTM

guru-aot

LGTM, nice work @sh16011993

andrepestana-aot

Great job!

#1851 - Enabled File Upload for Public Institution User

a244228

- Remove upload file button. - Disable links to download/view the file. - Wrote E2E tests.

sh16011993 added User Experience task that relates to UI UX Content Tasks related to UIUX content SIMS-Api SIMS-Api E2E/Unit tests labels Apr 19, 2023

sh16011993 self-assigned this Apr 19, 2023

sh16011993 requested review from andrewsignori-aot, ann-aot, dheepak-aot, guru-aot, andrepestana-aot, hellolynn-tbtb and JasonCTang April 19, 2023 07:57

sh16011993 removed the Content Tasks related to UIUX content label Apr 19, 2023

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/backend/libs/test-utils/src/factories/student-file-uploads.ts Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/backend/libs/test-utils/src/factories/student-file-uploads.ts Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

...ollers/student/_tests_/e2e/student.institutions.controller.getStudentFileUploads.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/backend/apps/api/src/route-controllers/student/models/student.dto.ts Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/web/src/components/common/students/StudentFileUploads.vue Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/web/src/components/common/students/StudentFileUploads.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Apr 19, 2023

View reviewed changes

...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Apr 19, 2023

View reviewed changes

...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/web/src/components/common/students/StudentFileUploads.vue Show resolved Hide resolved

dheepak-aot reviewed Apr 19, 2023

View reviewed changes

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/web/src/components/common/students/StudentFileUploads.vue Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/web/src/services/http/StudentApi.ts Outdated Show resolved Hide resolved

ann-aot reviewed Apr 19, 2023

View reviewed changes

sources/packages/web/src/services/http/dto/Student.dto.ts Outdated Show resolved Hide resolved

andrepestana-aot reviewed Apr 19, 2023

View reviewed changes

...ollers/student/_tests_/e2e/student.institutions.controller.getStudentFileUploads.e2e-spec.ts Show resolved Hide resolved

sh16011993 added 4 commits April 21, 2023 12:51

Code update with review comments

68680e6

Updated code to revert the template code for Upload Button and the Mo…

9da7fb9

…dal to the common component

Updated code with review comments

3f9160c

Updated code with review comments

0302b1e

andrewsignori-aot reviewed Apr 24, 2023

View reviewed changes

sources/packages/backend/apps/api/src/route-controllers/student/student.controller.service.ts Show resolved Hide resolved

andrewsignori-aot reviewed Apr 24, 2023

View reviewed changes

sources/packages/web/src/components/common/students/StudentFileUploads.vue Outdated Show resolved Hide resolved

andrewsignori-aot reviewed Apr 24, 2023

View reviewed changes

sources/packages/web/src/views/aest/student/FileUploads.vue Outdated Show resolved Hide resolved

andrewsignori-aot reviewed Apr 24, 2023

View reviewed changes

dheepak-aot reviewed Apr 24, 2023

View reviewed changes

Updated code with review comments

c0b206a

ann-aot approved these changes Apr 24, 2023

View reviewed changes

ann-aot reviewed Apr 24, 2023

View reviewed changes

andrewsignori-aot approved these changes Apr 25, 2023

View reviewed changes

sh16011993 requested review from dheepak-aot, andrepestana-aot and guru-aot April 25, 2023 02:04

dheepak-aot approved these changes Apr 25, 2023

View reviewed changes

guru-aot approved these changes Apr 25, 2023

View reviewed changes

andrepestana-aot approved these changes Apr 25, 2023

View reviewed changes

sh16011993 merged commit d5734da into main Apr 25, 2023

sh16011993 deleted the 1851_enable_file_upload_tab_public_institution_user branch April 25, 2023 16:19

sh16011993 temporarily deployed to DEV April 25, 2023 16:19 — with GitHub Actions Inactive

sh16011993 temporarily deployed to DEV April 25, 2023 16:30 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1851 - Enable File Upload for Public Institution User #1893

#1851 - Enable File Upload for Public Institution User #1893

sh16011993 commented Apr 19, 2023

dheepak-aot Apr 19, 2023

dheepak-aot Apr 19, 2023

ann-aot Apr 19, 2023

dheepak-aot commented Apr 21, 2023

andrewsignori-aot left a comment

dheepak-aot Apr 24, 2023 •

edited

Loading

sh16011993 Apr 24, 2023

andrewsignori-aot Apr 25, 2023

dheepak-aot Apr 25, 2023

sonarqubecloud bot commented Apr 24, 2023

github-actions bot commented Apr 24, 2023

github-actions bot commented Apr 24, 2023

github-actions bot commented Apr 24, 2023

ann-aot left a comment

ann-aot left a comment

github-actions bot commented Apr 25, 2023

andrewsignori-aot left a comment

dheepak-aot left a comment

guru-aot left a comment

andrepestana-aot left a comment

#1851 - Enable File Upload for Public Institution User #1893

#1851 - Enable File Upload for Public Institution User #1893

Conversation

sh16011993 commented Apr 19, 2023

dheepak-aot Apr 19, 2023

Choose a reason for hiding this comment

dheepak-aot Apr 19, 2023

Choose a reason for hiding this comment

ann-aot Apr 19, 2023

Choose a reason for hiding this comment

dheepak-aot commented Apr 21, 2023

andrewsignori-aot left a comment

Choose a reason for hiding this comment

dheepak-aot Apr 24, 2023 • edited Loading

Choose a reason for hiding this comment

sh16011993 Apr 24, 2023

Choose a reason for hiding this comment

andrewsignori-aot Apr 25, 2023

Choose a reason for hiding this comment

dheepak-aot Apr 25, 2023

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 24, 2023

github-actions bot commented Apr 24, 2023

Backend Unit Tests Coverage Report

github-actions bot commented Apr 24, 2023

E2E Workflow Workers Coverage Report

github-actions bot commented Apr 24, 2023

E2E Queue Consumers Coverage Report

ann-aot left a comment

Choose a reason for hiding this comment

ann-aot left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 25, 2023

E2E SIMS API Coverage Report

andrewsignori-aot left a comment

Choose a reason for hiding this comment

dheepak-aot left a comment

Choose a reason for hiding this comment

guru-aot left a comment

Choose a reason for hiding this comment

andrepestana-aot left a comment

Choose a reason for hiding this comment

dheepak-aot Apr 24, 2023 •

edited

Loading