Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1786 - Enable Search Student for Institutions part 2 #1887

Merged
merged 12 commits into from
Apr 19, 2023
Merged

#1786 - Enable Search Student for Institutions part 2 #1887

merged 12 commits into from
Apr 19, 2023

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Apr 13, 2023 •
edited
Loading

  • Added BC Public institution (COLLF) to test seed data;
  • Added COLLF users to test-utils;
  • Adjusted query to not get either Cancelled applications that weren't assessed or Draft applications;
  • Persisted institution location at the submit time;
  • Removed application update for institution location from PIR process;
  • Updated comment on sims.applications.location_id;
  • Added E2E testes for the search student API.
  • Fixed responsiveness for the form:
    image
    image

@andrepestana-aot
- Added BC Public institution (COLLF) to test seed data;
55dcf0f 
- Added COLLF users to test-utils;
- Adjusted query to not get Cancelled applications that weren't assessed;
- Persisted institution location at the submit time;
- Removed application update for institution location from PIR process;
- Updated comment on application.location_id;
@andrepestana-aot andrepestana-aot changed the title #1786 - Enable Search Student for Institutions #1786 - Enable Search Student for Institutions part 2 Apr 13, 2023
@andrepestana-aot andrepestana-aot self-assigned this Apr 13, 2023
@andrepestana-aot andrepestana-aot marked this pull request as ready for review April 14, 2023 18:24
@guru-aot
Copy link
Collaborator

guru-aot commented Apr 17, 2023 •
edited
Loading

Good work @andrepestana-aot . please take a look at the comment. Not a blocker, just a general qn that came to my mind, maybe for the business or devs, while institutions search for a student, should they be able to see an archived student application? @JasonCTang @andrewsignori-aot @dheepak-aot @guru-aot

I am not sure whether to see an archived application done by a student came as a requirement for us. the better one to answer would be @JasonCTang and business

guru-aot
guru-aot reviewed Apr 17, 2023
View reviewed changes
sources/packages/backend/apps/api/src/services/student/student.service.ts
.leftJoin("offering.institutionLocation", "offeringLocation")
.leftJoin("offeringLocation.institution", "offeringInstitution");
.innerJoin("application.location", "institutionLocation")
.innerJoin("institutionLocation.institution", "institution");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrepestana-aot

ann-aot
ann-aot reviewed Apr 17, 2023
View reviewed changes
...s/packages/backend/apps/api/src/route-controllers/student/student.institutions.controller.ts
* TODO add decorator to restrict to BC Public institutions.
* @param searchCriteria criteria to be used in the search.
* @returns searched student details.
*/
@Post("search")
@HttpCode(HttpStatus.OK)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrewsignori-aot
andrewsignori-aot reviewed Apr 17, 2023
View reviewed changes
...e-controllers/student/_tests_/e2e/student.institutions.controller.searchStudents.e2e-spec.ts Outdated
let collegeFLocation: InstitutionLocation;
let studentRepo: Repository<Student>;
let applicationRepo: Repository<Application>;
let collegeFInstitutionUserToken;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please type this to avoid VSCode waning.
image

andrewsignori-aot
andrewsignori-aot reviewed Apr 17, 2023
View reviewed changes
sources/packages/backend/libs/test-utils/src/factories/application.ts Outdated
@@ -154,5 +192,8 @@ export async function saveFakeApplicationDisbursements(
fakeOriginalAssessment,
);
savedApplication.currentAssessment = savedOriginalAssessment;
if (options?.applicationStatus === ApplicationStatus.Draft) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to make it null at this point? If so, we need also to take care of the savedApplication.currentAssessment for instance.
If the problem is related to having an intitutionLocation associated with the offering and application location, we can also receive two locations on the relations options.

andrewsignori-aot
andrewsignori-aot reviewed Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. Few minor comments only.

@dheepak-aot
Copy link
Collaborator

Thanks for doing the changes @andrepestana-aot. Added one more comment.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.95% ( 1961 / 10926 )
Methods: 8.1% ( 115 / 1419 )
Lines: 20.64% ( 1717 / 8317 )
Branches: 10.84% ( 129 / 1190 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 65.01% ( 353 / 543 )
Methods: 53.62% ( 37 / 69 )
Lines: 67.24% ( 312 / 464 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 38.9% ( 2638 / 6782 )
Methods: 30.84% ( 272 / 882 )
Lines: 44.36% ( 2244 / 5059 )
Branches: 14.51% ( 122 / 841 )

dheepak-aot
dheepak-aot approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes @andrepestana-aot . LGTM 👍

andrewsignori-aot
andrewsignori-aot approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes and really nice coverage on the search scenarios for E2E tests.

ann-aot
ann-aot approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @andrepestana-aot Thanks for doing the changes 👍

sh16011993
sh16011993 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andrepestana-aot andrepestana-aot merged commit bd603d3 into main Apr 19, 2023
@andrepestana-aot andrepestana-aot temporarily deployed to DEV April 19, 2023 00:45 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot deleted the 1786_enable_search_student_for_institutions_part2 branch April 19, 2023 00:45
@andrepestana-aot andrepestana-aot temporarily deployed to DEV April 19, 2023 00:46 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV April 19, 2023 01:00 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrepestana-aot andrepestana-aot

Labels
E2E/Unit tests Institution Institution Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrepestana-aot @dheepak-aot @andrewsignori-aot @guru-aot @sh16011993 @ann-aot