#1724 - E2E/Units Tests - Review Queue Consumers E2E Tests #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsignori-aot
changed the title
…ub.com/bcgov/SIMS into feature/#1724-queue-conumers-e2e-tests
andrewsignori-aot
requested review from
dheepak-aot,
andrepestana-aot,
sh16011993,
ann-aot,
JasonCTang and
guru-aot
ann-aot
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Good work @andrewsignori-aot 👍 Only minor comments. Approving the PR
ann-aot
reviewed
Apr 12, 2023
...ntegration/ecert-integration/tests/ecert-full-time-process-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Apr 12, 2023
...packages/backend/apps/queue-consumers/test/helpers/testing-modules/testing-modules-helper.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Apr 12, 2023
...sumers/src/processors/assessment/_tests_/cancel-application-assessment.processor.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Apr 12, 2023
...sumers/src/processors/assessment/_tests_/cancel-application-assessment.processor.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Apr 12, 2023
...sumers/src/processors/assessment/_tests_/cancel-application-assessment.processor.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Apr 12, 2023
...sumers/src/processors/assessment/_tests_/cancel-application-assessment.processor.e2e-spec.ts
Outdated
Show resolved
Hide resolved
|
Thanks for creating E2E test foundation for queue consumers. Added some comments. |
...egration/ecert-integration/_tests_/ecert-full-time-process-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrepestana-aot
approved these changes
Apr 13, 2023
dheepak-aot
approved these changes
Apr 13, 2023
guru-aot
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createTestingAppModuleto start the queue-consumers module for all E2E tests.describeProcessorRootTestwith the intention to create a similar one for the scheduler in the future.@golevelup/ts-jestreferenced on Nestjs documentation (https://docs.nestjs.com/fundamentals/testing). The idea is to validate how useful it can be and assess if it is needed or not.start-application-assessmentandcancel-application-assessment, as shown below.ecert-full-time-process-integration.scheduler.e2e-specis not the focus of this PR. It was just adjusted to fit better in the new E2E structure.Processor E2E tests for start-application-assessment
√ Should throw an error when the workflow createProcessInstance method throws an error.
√ Should invoke the workflow create instance method with the received job parameters.
Processor E2E tests for cancel-application-assessment
√ Should cancel pending disbursements and rollback overawards when the cancelled application has overawards and also one sent and one pending disbursements.
√ Should cancel workflow and log a warning when the workflowInstanceId is not present.
√ Should throw an error and call job.discard when the application is not in the expected status.
√ Should throw an error and call job.discard when the assessment id was not found.