Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1788 - Institution student profile #1863

Merged
merged 16 commits into from
Apr 11, 2023
Merged

#1788 - Institution student profile #1863

merged 16 commits into from
Apr 11, 2023

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Apr 6, 2023 •
edited
Loading

Institution view student profile

  • Convert the form (studentProfileSummary) to vuetify component

image

  • Form definition studentProfileSummary has been removed.
  • Minor refactors done in student.controller.service.ts and StudentRestrictionChip.vue to get the props typed.
  • The authorization for API will be handled in Authorization for public vs non-public institutions #1830 as discussed with team. Todo comments added for this authorization part.
  • Routes and Vue files created for other student tabs.
    image

@dheepak-aot dheepak-aot added Web Portal SIMS-Api SIMS-Api Form.io Form IO definitions changed. labels Apr 6, 2023
@dheepak-aot dheepak-aot self-assigned this Apr 6, 2023
@dheepak-aot dheepak-aot marked this pull request as ready for review April 11, 2023 00:39
@ann-aot
Copy link
Contributor

ann-aot commented Apr 11, 2023 •
edited
Loading

Institution view student profile

  • Convert the form (studentProfileSummary) to vuetify component

image

I am seeing the red-marked items missing, is it, not part of the PR,
image
and orange marked wording seems different.

@dheepak-aot
Copy link
Collaborator Author

Institution view student profile

  • Convert the form (studentProfileSummary) to vuetify component

image

I am seeing the red-marked items missing, is it, not part of the PR, image and orange marked wording seems different.

Yes as discussed these changes are not considered in scope of the story.

ann-aot
ann-aot reviewed Apr 11, 2023
View reviewed changes
sources/packages/web/src/types/contracts/StudentContract.ts
birthDateFormatted: string;
}

export interface AESTStudentForm extends StudentFormInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgov/SIMS/pull/1863/files#r1163175201

guru-aot
guru-aot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the placeholder pages, Please work on the other devs comments. Nice work @dheepak-aot

sources/packages/web/src/views/institution/student/InstitutionStudentApplications.vue
@@ -0,0 +1,3 @@
<template>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

ann-aot
ann-aot reviewed Apr 11, 2023
View reviewed changes
sources/packages/web/src/views/aest/student/StudentDetails.vue
@@ -120,21 +111,13 @@ export default defineComponent({
},
]);

const goBack = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @dheepak-aot . added some comments

andrewsignori-aot
andrewsignori-aot reviewed Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks for the placeholders also.
Please take a look at the comments.

andrepestana-aot
andrepestana-aot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ann-aot
Copy link
Contributor

ann-aot commented Apr 11, 2023

Institution view student profile

  • Convert the form (studentProfileSummary) to vuetify component

image

I am seeing the red-marked items missing, is it, not part of the PR, image and orange marked wording seems different.

Yes as discussed these changes are not considered in scope of the story.

just to double check what about the yellow marked title? are we not considering in the PR

@dheepak-aot
Copy link
Collaborator Author

Institution view student profile

  • Convert the form (studentProfileSummary) to vuetify component

image

I am seeing the red-marked items missing, is it, not part of the PR, image and orange marked wording seems different.

Yes as discussed these changes are not considered in scope of the story.

just to double check what about the yellow marked title? are we not considering in the PR

The intention of this ticket is to replicate the details what we have in ministry and any further changes in UI was decided to handled in separate ticket which involves anything that needs to be changed in the UI for both ministry and institution.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.99% ( 1960 / 10892 )
Methods: 8.12% ( 115 / 1417 )
Lines: 20.71% ( 1716 / 8286 )
Branches: 10.85% ( 129 / 1189 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 56.72% ( 308 / 543 )
Methods: 46.38% ( 32 / 69 )
Lines: 59.48% ( 276 / 464 )
Branches: 0% ( 0 / 10 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 32.41% ( 176 / 543 )
Methods: 21.25% ( 17 / 80 )
Lines: 39.25% ( 157 / 400 )
Branches: 3.17% ( 2 / 63 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 38.41% ( 2602 / 6775 )
Methods: 30.24% ( 267 / 883 )
Lines: 43.95% ( 2221 / 5053 )
Branches: 13.59% ( 114 / 839 )

andrewsignori-aot
andrewsignori-aot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, look good 👍

ann-aot
ann-aot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @dheepak-aot 👍 Thanks for doing the changes 👍

@dheepak-aot dheepak-aot merged commit efc4808 into main Apr 11, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV April 11, 2023 23:21 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV April 11, 2023 23:22 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV April 11, 2023 23:33 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the feature/institution-student-profile branch April 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@dheepak-aot dheepak-aot

Labels
Form.io Form IO definitions changed. SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dheepak-aot @ann-aot @andrewsignori-aot @guru-aot @andrepestana-aot