#1761 - Handling full time BCSL lifetime and federal maximums - DB migrations #1860
Conversation
ann-aot
requested review from
andrepestana-aot,
dheepak-aot,
andrewsignori-aot,
sh16011993,
guru-aot and
JasonCTang
and removed request for
andrepestana-aot and
dheepak-aot
andrewsignori-aot
changed the title
...s/db-migrations/src/sql/DisbursementValues/Add-restriction-amount-and-id-subtracted-cols.sql
Outdated
Show resolved
Hide resolved
.../packages/backend/apps/db-migrations/src/sql/ProgramYear/Add-max-lifetime-bc-loan-amount.sql
Outdated
Show resolved
Hide resolved
| @@ -14,5 +15,6 @@ export function createFakeProgramYear(programYearPrefix?: number): ProgramYear { | |||
| programYear.parentFormName = `${programYear.formName}-parent`; | |||
| programYear.partnerFormName = `${programYear.formName}-partner`; | |||
| programYear.programYearPrefix = programYearPrefix.toString(); | |||
| programYear.maxLifetimeBCLoanAmount = faker.random.number(100000); | |||
There was a problem hiding this comment.
I believe we can give an actual number rather giving a random number. As during the lifetime maximums calculations, if this is created, it will be helpful to do the expect.
There was a problem hiding this comment.
It will not always be 50,000 for future program years I guess. but I got the point, I will change
| ) | ||
| VALUES | ||
| ( | ||
| 'Provincial', |
There was a problem hiding this comment.
Along with the development of this ticket, we can add the placeholder for this new restriction code on the student activity also.
There was a problem hiding this comment.
ya, I will add it. Thanks for the point. And I think we need to review the codes there in the UI, a few days back, when I was trying to find the details for a code, I couldn't find it there.
| nullable: true, | ||
| transformer: numericTransformer, |
| restrictionAmountSubtracted?: number; | ||
| /** | ||
| * References the restriction related to the disbursement | ||
| * due to which the amount for subtracted. |
There was a problem hiding this comment.
The "for" here seems lost, is it supposed to be "due to which the amount was subtracted"?
There was a problem hiding this comment.
updating to
* References the restriction related to the disbursement due to which the amount was subtracted.
There was a problem hiding this comment.
Looks good, just remove the additional white spaces in the middle of the proposed sentence.
sources/packages/backend/libs/sims-db/src/entities/disbursement-values.model.ts
Outdated
Show resolved
Hide resolved
...ces/packages/backend/apps/db-migrations/src/sql/Restrictions/Update-and-add-restrictions.sql
Outdated
Show resolved
Hide resolved
| ALTER TABLE | ||
| sims.program_years | ||
| ADD | ||
| COLUMN max_lifetime_bc_loan_amount NUMERIC(8, 2) NOT NULL DEFAULT 0; |
There was a problem hiding this comment.
We can default it to 50000 and skip the update query below.
sources/packages/backend/libs/sims-db/src/entities/disbursement-values.model.ts
Show resolved
Hide resolved
|
Nice work @ann-aot . few minor comments. Also there is minor sonar cloud code smell on import. |
| ) | ||
| restrictionIdSubtracted?: number; | ||
| /** | ||
| *Restriction id due to which the award amount was reduced. |
There was a problem hiding this comment.
Please add a white space after the "*".
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
IF EXISTSin the queriesnumericTransformerto numeric fieldtuition_remittance_effective_amountUPDATE:
resctrictionCatergoryupdated toOtherfor the new restrictionBCLMupon confirmation