#1837 - Fix missing details on submitting Designation Request

sources/packages/backend/apps/api/src/route-controllers/designation-agreement/designation-agreement.institutions.controller.ts

@@ -25,6 +25,7 @@ import {
 import { InstitutionUserRoles } from "../../auth/user-types.enum";
 import { FormNames } from "../../services/form/constants";
 import { DesignationAgreementControllerService } from "./designation-agreement.controller.service";
+import { InstitutionControllerService } from "../institution/institution.controller.service";
 import {
   ApiBadRequestResponse,
   ApiForbiddenResponse,
@@ -46,6 +47,7 @@ export class DesignationAgreementInstitutionsController extends BaseController {
     private readonly designationAgreementService: DesignationAgreementService,
     private readonly formService: FormService,
     private readonly designationAgreementControllerService: DesignationAgreementControllerService,
+    private readonly institutionControllerService: InstitutionControllerService,
   ) {
     super();
   }
@@ -81,6 +83,15 @@ export class DesignationAgreementInstitutionsController extends BaseController {
         "User does not have the rights to create a designation agreement.",
       );
     }
+
+    // Check if institution is private or public and append it to the payload
+    const isInstitutionPrivate =
+      await this.institutionControllerService.checkIfInstitutionIsPrivate(
+        userToken.authorizations.institutionId,
+      );
+
+    payload.isBCPrivate = isInstitutionPrivate;
+
     // Validate the dynamic data submission.
     const submissionResult = await this.formService.dryRunSubmission(
       FormNames.DesignationAgreementDetails,
@@ -106,7 +117,9 @@ export class DesignationAgreementInstitutionsController extends BaseController {
     const createdDesignation =
       await this.designationAgreementService.submitDesignationAgreement(
         userToken.authorizations.institutionId,
-        submissionResult.data.data.dynamicData,
+        submissionResult.data.data.dynamicData
+          ? submissionResult.data.data.dynamicData
+          : {},
         userToken.userId,
         payload.locations
           .filter((location) => location.requestForDesignation)

sources/packages/backend/apps/api/src/route-controllers/designation-agreement/models/designation-agreement.dto.ts

@@ -75,6 +75,11 @@ export class SubmitDesignationAgreementAPIInDTO {
   @ValidateNested({ each: true })
   @Type(() => SubmittedLocationsAPIInDTO)
   locations: SubmittedLocationsAPIInDTO[];
+
+  /**
+   * Indicates if Institution is private or public
+   */
+  isBCPrivate: boolean;
 }
 
 /**

sources/packages/backend/apps/api/src/route-controllers/institution/institution.controller.service.ts

@@ -80,4 +80,15 @@ export class InstitutionControllerService {
       description: institutionType.name,
     }));
   }
+
+  /**
+   * Check if institution is private or public.
+   * @param institutionId is the institution id.
+   * @returns boolean true if institution is private, else false.
+   */
+  async checkIfInstitutionIsPrivate(institutionId: number): Promise<boolean> {
+    const institutionType =
+      await this.institutionService.getInstitutionTypeById(institutionId);
+    return INSTITUTION_TYPE_BC_PRIVATE === institutionType.institutionType.id;
+  }
 }

sources/packages/backend/apps/api/src/services/institution/institution.service.ts

@@ -694,6 +694,27 @@ export class InstitutionService extends RecordDataModelService<Institution> {
       .getOne();
   }
 
+  /**
+   * Get the institutionType by institution id.
+   * @param institutionId Institution id.
+   * @returns Institution retrieved, if found, otherwise returns null.
+   */
+  async getInstitutionTypeById(institutionId: number): Promise<Institution> {
+    return this.repo.findOne({
+      select: {
+        institutionType: {
+          id: true,
+        },
+      },
+      where: {
+        id: institutionId,
+      },
+      relations: {
+        institutionType: true,
+      },
+    });
+  }
+
   /**
    * Get the basic info of the institution by ID.
    * @param institutionId Institution id.