Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1712 - Students overawards UI - Part 1 #1846

Merged
merged 25 commits into from
Mar 29, 2023
Merged

#1712 - Students overawards UI - Part 1 #1846

merged 25 commits into from
Mar 29, 2023

Conversation

guru-aot
Copy link
Collaborator

Student Overawards UI

  • Create a new page called "Overawards Balance"
  • Under the avatar menu add an item called "Overawards Balance" and ensure the item is "active" blue
  • On the page, add a card with content and image (include an alt tag on the image)
  • Display the component (same as ministry user)
  • Remove the ("Added by") in the "Overaward deductions" table
  • Remove the "add a manual record" button in the "Overaward deductions" table
  • If there are no data in the table, display the "no items here" pattern
  • Type in data table is not displaying hypen when no value found. It must be fixed.
    image
    image
    image

@guru-aot guru-aot added Enhancement New feature or request User Story Student Student Features labels Mar 28, 2023
@andrewsignori-aot andrewsignori-aot changed the title #1712 - Students over awards UI - Part 1 #1712 - Students overawards UI - Part 1 Mar 29, 2023
ann-aot
ann-aot reviewed Mar 29, 2023
View reviewed changes
sources/packages/web/src/services/OverawardService.ts Outdated
payload: OverawardManualRecordAPIInDTO,
studentId?: number,
Copy link
Contributor

@ann-aot ann-aot Mar 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why studentId optional for manual overaward?? am i missing something

ann-aot
ann-aot reviewed Mar 29, 2023
View reviewed changes
sources/packages/web/src/services/http/OverawardApi.ts Outdated
payload: OverawardManualRecordAPIInDTO,
studentId?: number,
Copy link
Contributor

@ann-aot ann-aot Mar 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why studentId? is optional and if its, it's not taken care of while the API call

dheepak-aot
dheepak-aot reviewed Mar 29, 2023
View reviewed changes
sources/packages/web/src/services/OverawardService.ts Outdated
payload: OverawardManualRecordAPIInDTO,
studentId?: number,
Copy link
Collaborator

@dheepak-aot dheepak-aot Mar 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we go with this approach.?. From the addManualOveraward perspective studentId cannot be optional.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted it back, was doing it for a different change.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot Mar 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dheepak-aot @ann-aot I believe that it happened by a mistake/misunderstood in one of the conversations that I had with @guru-aot. I was trying to get rid of the props.studentId as number but forgot that the method would be not used by the student.
Either way, I would still prefer a change like below to avoid the as number in that context that looks more like a workaround, but this is just a suggestion.
image

ann-aot
ann-aot reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @guru-aot . added some comments

dheepak-aot
dheepak-aot approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes @guru-aot .

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.03% ( 1955 / 10841 )
Methods: 8.17% ( 115 / 1408 )
Lines: 20.74% ( 1711 / 8251 )
Branches: 10.91% ( 129 / 1182 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 31.39% ( 167 / 532 )
Methods: 20.51% ( 16 / 78 )
Lines: 38.3% ( 149 / 389 )
Branches: 3.08% ( 2 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 56.72% ( 308 / 543 )
Methods: 46.38% ( 32 / 69 )
Lines: 59.48% ( 276 / 464 )
Branches: 0% ( 0 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 38.04% ( 2560 / 6729 )
Methods: 29.79% ( 261 / 876 )
Lines: 43.65% ( 2191 / 5019 )
Branches: 12.95% ( 108 / 834 )

andrewsignori-aot
andrewsignori-aot approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, look good 👍

andrepestana-aot
andrepestana-aot approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

ann-aot
ann-aot approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @guru-aot 👍 Thanks for doing the changes

@guru-aot guru-aot self-assigned this Mar 29, 2023
@guru-aot guru-aot merged commit 955f54b into main Mar 29, 2023
@guru-aot guru-aot temporarily deployed to DEV March 29, 2023 19:32 — with GitHub Actions Inactive
@guru-aot guru-aot deleted the feature/1712-StudentsOverAwardsUI-Part-1 branch March 29, 2023 19:32
@guru-aot guru-aot temporarily deployed to DEV March 29, 2023 19:32 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV March 29, 2023 19:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellolynn-tbtb hellolynn-tbtb hellolynn-tbtb left review comments

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@guru-aot guru-aot

Labels
Enhancement New feature or request SIMS-Api SIMS-Api Student Student Features User Story
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guru-aot @dheepak-aot @hellolynn-tbtb @andrewsignori-aot @ann-aot @andrepestana-aot