-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1712 - Students overawards UI - Part 1 #1846
Conversation
sources/packages/web/src/views/student/StudentOverawardsBalance.vue
Outdated
Show resolved
Hide resolved
...es/packages/backend/apps/api/src/route-controllers/overaward/overaward.controller.service.ts
Outdated
Show resolved
Hide resolved
...es/packages/backend/apps/api/src/route-controllers/overaward/overaward.controller.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/route-controllers/overaward/overaward.aest.controller.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/route-controllers/overaward/overaward.aest.controller.ts
Outdated
Show resolved
Hide resolved
...s/packages/backend/apps/api/src/route-controllers/overaward/overaward.students.controller.ts
Outdated
Show resolved
Hide resolved
payload: OverawardManualRecordAPIInDTO, | ||
studentId?: number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why studentId
optional for manual overaward?? am i missing something
payload: OverawardManualRecordAPIInDTO, | ||
studentId?: number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why studentId?
is optional and if its, it's not taken care of while the API call
payload: OverawardManualRecordAPIInDTO, | ||
studentId?: number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we go with this approach.?. From the addManualOveraward perspective studentId cannot be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted it back, was doing it for a different change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dheepak-aot @ann-aot I believe that it happened by a mistake/misunderstood in one of the conversations that I had with @guru-aot. I was trying to get rid of the props.studentId as number
but forgot that the method would be not used by the student.
Either way, I would still prefer a change like below to avoid the as number
in that context that looks more like a workaround, but this is just a suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @guru-aot . added some comments
...s/packages/backend/apps/api/src/route-controllers/overaward/overaward.students.controller.ts
Outdated
Show resolved
Hide resolved
...s/packages/backend/apps/api/src/route-controllers/overaward/overaward.students.controller.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes @guru-aot .
sources/packages/backend/apps/api/src/route-controllers/overaward/models/overaward.dto.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes, look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @guru-aot 👍 Thanks for doing the changes
Student Overawards UI