PR comments

sources/packages/backend/apps/api/src/route-controllers/application/_tests_/application.students.getCompletedApplicationDetails.e2e-spec.ts

@@ -149,13 +149,13 @@ describe("ApplicationStudentsController(e2e)-getCompletedApplicationDetails", ()
     firstDisbursement.coeStatus = COEStatus.completed;
     await disbursementScheduleRepo.save(firstDisbursement);
     // Create a scholastic standing and have it associated with the completed application.
+    // 'Student did not complete program' is the only 'scholastic standing that does not generate an assessment.
+    // The below record has only a relationship with the application which must be enough to
+    // have the scholasticStandingChangeType returned.
     const scholasticStanding = createFakeStudentScholasticStanding({
       submittedBy: submittedByInstitutionUser,
+      application,
     });
-    // 'Student did not complete program' is the only'scholastic standing that does not generate an assessment.
-    // The below record has only a relationship with the application which must be enough to
-    // have the scholasticStandingChangeType returned.
-    scholasticStanding.application = application;
     await studentScholasticStandingRepo.save(scholasticStanding);
 
     const endpoint = `/students/application/${application.id}/completed`;

sources/packages/backend/libs/test-utils/src/factories/application.ts

@@ -140,6 +140,5 @@ export async function saveFakeApplicationDisbursements(
     fakeOriginalAssessment,
   );
   savedApplication.currentAssessment = savedOriginalAssessment;
-  savedApplication.applicationStatus = ApplicationStatus.Enrolment;
   return applicationRepo.save(savedApplication);
 }