Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX][Web][SIMS #1450] UI Content for Institution - Login #1459

Merged
merged 5 commits into from
Oct 17, 2022

Conversation

hellolynn-tbtb
Copy link
Contributor

@hellolynn-tbtb hellolynn-tbtb commented Oct 14, 2022

  1. Updated content for institution login
  2. Updated error messages - note one of the error message has not been updated as it is flagged for removal (future ticket)
  3. Removed columns in card
  4. Removed custom style

image

Figma reference

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Congrats on the first PR approval 🥳

@@ -107,8 +95,3 @@ export default {
},
};
</script>
<style scoped>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed but the class name is still consumed in line 23. Is it right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewsignori-aot! I will remove the class. Looks like no additional styles are attached, so the class is pointless now.

User ID. Learn how to setup and access your account
<a
rel="noopener"
target="_blank"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add class="primary-color" for the brand blue color, i believe else it will be default href color

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @hellolynn-tbtb . one minor comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes 👍 already approved 😄

@hellolynn-tbtb hellolynn-tbtb merged commit b006db2 into main Oct 17, 2022
@hellolynn-tbtb hellolynn-tbtb deleted the content/#1450-UI-Content-for-Institutions branch October 17, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants