-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX][Web][SIMS #1450] UI Content for Institution - Login #1459
[UX][Web][SIMS #1450] UI Content for Institution - Login #1459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Congrats on the first PR approval 🥳
@@ -107,8 +95,3 @@ export default { | |||
}, | |||
}; | |||
</script> | |||
<style scoped> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed but the class name is still consumed in line 23. Is it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrewsignori-aot! I will remove the class. Looks like no additional styles are attached, so the class is pointless now.
User ID. Learn how to setup and access your account | ||
<a | ||
rel="noopener" | ||
target="_blank" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add class="primary-color" for the brand blue color, i believe else it will be default href color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @hellolynn-tbtb . one minor comment
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes 👍 already approved 😄
Figma reference