Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT - Program Year Limits #4015

Closed
7 of 18 tasks
CarlyCotton opened this issue Nov 29, 2024 · 1 comment
Closed
7 of 18 tasks

FT - Program Year Limits #4015

CarlyCotton opened this issue Nov 29, 2024 · 1 comment
Assignees

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Nov 29, 2024

User Story
As a student, I am subject to a number of program year totals within my financial aid assessment. Some, like the award program year limits, have already been worked on and identified by PT assessment. New items we need to be saved and persisted across future applications just like PY limits.

Acceptance Criteria

For every FT assessment we need to save the following variables to workflow data to be used in other applications in the same program year:

  • calculatedDataExemptScholarshipsBursaries
  • calculatedDataSpouseContributionWeeks
  • calculatedDataTotalFederalFSC
  • calculatedDataTotalProvincialFSC

Provide a way in Camunda to access these variables and use in calculations:

  • programYearTotalScholarshipsBursaries
  • programYearTotalSpouseContributionWeeks
  • programYearTotalFederalFSC
  • programYearTotalProvincialFSC

Technical

  • No SFAS related data required.
  • Save any variable not present yet into the workflow_data to allow the SUM.
  • Follow the same logic from getProgramYearPreviousAwardsTotals
  • Create a private method to handle the existing programYearTotal logo plus the new one.
  • Ensure the processing will happen only for Full-time.
  • The final goal of the ticket is to make the new programYearTotal* variables present in the assessment-gateway and this is what should be demoed.
  • PR separation suggestion.
    • Workflows related changes.
    • The new method similar to the getProgramYearPreviousAwardsTotals.
  • E2E tests.
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Nov 29, 2024
@CarlyCotton CarlyCotton self-assigned this Nov 30, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Dec 3, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Dec 3, 2024
@CarlyCotton
Copy link
Collaborator Author

Updated the ACs to change the variable to save for the scholarships and bursaries:
calculatedDataExemptScholarshipsBursaries

@guru-aot guru-aot self-assigned this Dec 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 23, 2024
- AssessmentGateway workflow has been changed to save the following data
in the workflow data
> - calculatedDataExemptScholarshipsBursaries
> - calculatedDataSpouseContributionWeeks
> - calculatedDataTotalFederalFSC
> - calculatedDataTotalProvincialFSC


![image](https://github.com/user-attachments/assets/a58ee079-0016-4d17-9a66-c07fa46f6dd6)

- Refactored the method
[getProgramYearPreviousAwardsTotals](https://github.com/bcgov/SIMS/blob/main/sources/packages/backend/libs/services/src/students-assessments/assessment-sequential-processing.service.ts#L148)
to reduce the call to the database in fetching the sequenced application
and assessment.
- Created a private method as requested in the ticket and additionally
created another method getFTProgramYearContributionTotals to process the
contribution total logic.
- E2E test case was updated to show the created variables and new E2E
created to test the sum logic in the query.
> - programYearTotalScholarshipsBursaries
> - programYearTotalSpouseContributionWeeks
> - programYearTotalFederalFSC
> - programYearTotalProvincialFSC

Note: PR separation is not done, as the workflow change was very minor
and it can be accommodated in a single PR.

---------

Co-authored-by: guru-aot <[email protected]>
@AnnaPBashkatova AnnaPBashkatova added this to the 2.2 Full-Time "Asset" milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants