Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAS Addressline1 Update - Restrict to Alpha Numeric #3983

Closed
5 of 6 tasks
CarlyCotton opened this issue Nov 22, 2024 · 0 comments
Closed
5 of 6 tasks

CAS Addressline1 Update - Restrict to Alpha Numeric #3983

CarlyCotton opened this issue Nov 22, 2024 · 0 comments
Assignees
@andrepestana-aot @CarlyCotton
Labels
Integration
Milestone
Full-Time "Asset"

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Nov 22, 2024 •
edited by andrepestana-aot
Loading

User Story
As a system integrating with CAS, I need to ensure my fields comply with what is expected.

Acceptance Criteria

  • When calling Create Site or Create Supplier and Site, we need to format the addressline 1 being sent:
    • Only alphanumeric characters, spaces, dashes (-)
    • Any special characters É (etc) should be converted like we do for other integrations (should already be happening)
    • Any other characters . , [ ] ( ) etc should be removed.
    • Truncate to 35 characters (should already be happening)

Technical

  • Update existing unit tests to validate the rules of the new character.
@CarlyCotton CarlyCotton added Business Items under Business Consideration Integration labels Nov 22, 2024
@CarlyCotton CarlyCotton self-assigned this Nov 22, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Nov 28, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Nov 28, 2024
@andrepestana-aot andrepestana-aot self-assigned this Dec 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@andrepestana-aot
#3983 - CAS Addressline1 Update - Restrict to Alpha Numeric (#4081)
89ac5d0 
- Added `replace(/[^A-Z0-9\-\s]/g, "")` to `formatAddress()` to remove
everything that is not A-Z (capital letters), hyphens or whitespace;
- Added invalid characters to unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrepestana-aot andrepestana-aot

@CarlyCotton CarlyCotton

Labels
Integration
Projects
None yet
Milestone
Full-Time "Asset"
Development

No branches or pull requests
5 participants
@ninosamson @andrewsignori-aot @andrepestana-aot @CarlyCotton @AnnaPBashkatova