Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Sequencing for FT and PT eCert Numbers #3965

Closed
7 tasks
ninosamson opened this issue Nov 19, 2024 · 0 comments
Closed
7 tasks

Separate Sequencing for FT and PT eCert Numbers #3965

ninosamson opened this issue Nov 19, 2024 · 0 comments

Comments

@ninosamson
Copy link
Collaborator

ninosamson commented Nov 19, 2024

User Story:
As a SIMS application, we need to have distinct document disbursement numbers for PT and FT eCerts.

Acceptance Criteria:

  • Separate document disbursement numbers for PT and FT
  • PT document disbursement number limit is 7 digits - add new attribute to PT existing "document_disbursement_number"
  • FT document disbursement number limit is 8 digits
  • Adjust environments closer to real production values for QA
    • For NON prod env: PT starting 200000
    • For NON prod env: FT starting 12000000

Additional Context

  • FT start number may need to be reassessed when preparing for FT launch to ensure it aligns with current SFAS doc numbers.
  • Sequence doesn't matter, confirmed by Finastra.

Technical

  • Append the offering intensity as a prefix following the same done for MSFAA.
  • Create the DB migration to rename the current DISBURSEMENT_DOCUMENT_NUMBER to Part Time_DISBURSEMENT_DOCUMENT_NUMBER.
  • Upinsert the mentioned values for non-PROD (DEV/TEST/Staging).
@ninosamson ninosamson added Business Items under Business Consideration Integration labels Nov 19, 2024
@ninosamson ninosamson self-assigned this Nov 19, 2024
@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Nov 26, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Nov 26, 2024
@bidyashish bidyashish self-assigned this Jan 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
**Technical** 
- [x] Append the offering intensity as a prefix following the same done
for MSFAA.
- [x] Create the DB migration to rename the current
`DISBURSEMENT_DOCUMENT_NUMBER` to `Part
Time_DISBURSEMENT_DOCUMENT_NUMBER`.
- [x] Upinsert the mentioned values for non-PROD (DEV/TEST/Staging).


 Db Migrations: Run

![image](https://github.com/user-attachments/assets/9883e731-542f-40e9-b011-2f46ddb0e15c)

 Db Migrations:: Demo

![image](https://github.com/user-attachments/assets/aa46f702-0d13-4cee-bbcb-ddc9e68bd8f9)


 Db Migrations: Revert

![image](https://github.com/user-attachments/assets/3e5a9da9-e7cb-4961-a358-151adf8a417e)

Up Insert:  non-PROD (DEV/TEST/Staging).

```
-- Part Time Document Number Sequence Control
UPDATE sims.sequence_controls
SET sequence_number = 200000
WHERE sequence_name = 'Part Time_DISBURSEMENT_DOCUMENT_NUMBER';

-- Full Time Document Number Sequence Control
UPDATE sims.sequence_controls
SET sequence_number = 12000000
WHERE sequence_name = 'Full Time_DISBURSEMENT_DOCUMENT_NUMBER';

```

Extra E2E Test
`sources/packages/backend/apps/api/src/route-controllers/confirmation-of-enrollment/_tests_/e2e/confirmation-of-enrollment.institutions.confirmEnrollment.e2e-spec.ts`


![image](https://github.com/user-attachments/assets/40346a5c-78df-440d-8930-4e80ce96a421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants