Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Name change for CRA Response file #3841

Closed
4 tasks done
JasonCTang opened this issue Oct 25, 2024 · 2 comments
Closed
4 tasks done

Hotfix: Name change for CRA Response file #3841

JasonCTang opened this issue Oct 25, 2024 · 2 comments
Assignees
@bidyashish
Labels
Integration
Milestone
Post Part-Time Pr...

Comments

@JasonCTang
Copy link
Collaborator

JasonCTang commented Oct 25, 2024 •
edited by dheepak-aot
Loading

The expected file name for the CRA Response file is changing to the following format:

Acceptance Criteria

  • Update CRA Response Integration job to search for new file name
    • [CRA Environment Code]BCSA#####.TXT
  • No change on request - confirmed with IMB CRA income verification request file name can remain the same.
  • In the request file, have the right CRA PROGRAM AREA CODE value coming in.

Context:
DEV: ABCSA#####.TXT
TEST: ABCSA#####.TXT
PROD: PBCSA#####.TXT

Current File Names for CRA Income:

  • CCRA_REQUEST_${this.craConfig.environmentCode}${sequenceFile}.DAT
  • /CCRA_RESPONSE_[\w]*.txt/i

For DEV environment:

  • Harry suggests that we use the A prefix from TEST, but if we ever send files from both environments, will need a way to coordinate the sequence number between the two.
@ninosamson ninosamson added Business Items under Business Consideration Integration labels Oct 25, 2024
@ninosamson ninosamson mentioned this issue Oct 25, 2024
Closed
@ninosamson ninosamson added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 29, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 30, 2024
@ninosamson ninosamson changed the title Name change for CRA Response file Hotfix: Name change for CRA Response file Oct 30, 2024
@bidyashish bidyashish self-assigned this Oct 31, 2024
@ninosamson ninosamson mentioned this issue Oct 31, 2024
Closed
8 tasks
bidyashish added a commit that referenced this issue Oct 31, 2024
@bidyashish
#3841 - Hotfix: Name change for CRA Response file (#3865)
47cc7d9 
Acceptance Criteria
- [x] Update CRA Response Integration job to search for new file name 
    - [x] [CRA Environment Code]BCSA#####.TXT
- [x] No change on request - confirmed with IMB CRA income verification
request file name can remain the same.

**Context:** 
DEV: ABCSA#####.TXT
TEST: ABCSA#####.TXT
PROD: PBCSA#####.TXT

**Current File Names for CRA Income:** 
- CCRA_REQUEST_${this.craConfig.environmentCode}${sequenceFile}.DAT
- /CCRA_RESPONSE_[\w]*\.txt/i

*note
Regex test

```
const environmentCode = 'A';
const regex = new RegExp(`[${environmentCode}]BCSA\\d{5}\\.TXT`, 'i');
const testString = 'ABCSA00001.TXT';

console.log(regex.test(testString)); // true
```
@CarlyCotton
Copy link
Collaborator

Successfully read in CRA response file with the new naming system.

@dheepak-aot
Copy link
Collaborator

@CarlyCotton @ninosamson Added an AC which mentions that the request file must have the correct CRA PROGRAM AREA CODE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bidyashish bidyashish

Labels
Integration
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
7 participants
@bidyashish @ninosamson @dheepak-aot @andrewsignori-aot @JasonCTang @CarlyCotton @michesmith