Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student: Sole custody dependant question change #3827

Closed
7 tasks done
JerPearson opened this issue Oct 23, 2024 · 3 comments
Closed
7 tasks done

Student: Sole custody dependant question change #3827

JerPearson opened this issue Oct 23, 2024 · 3 comments
Assignees
Labels
Student Student Features User Story

Comments

@JerPearson
Copy link
Collaborator

JerPearson commented Oct 23, 2024

On the family information tab move location of sole custody question to allow the question to be dependent specific.

Acceptance Criteria

  • Make these changes for the 25-26 program year application form
  • Move "Are any of the dependants listed above supported by you financially but not under your sole custody?" question to the Add Dependants box.
  • Revise question to: "Is the dependant listed above supported by you financially but not under your sole custody?"
  • This question should be included for each individual dependant added.
  • If possible please make it so that each individual dependant that has this exception selected has their own exception line on the ministry UI. If not possible due to effort or function one is fine for PT MVP.
  • Apply changes to FT/PT

image.png

Technical

  • The new exception will follow the solution in place using the same behavior from the exception created for "Declared on taxes due to a disability" which means that we will be complying with the AC that states "If not possible due to effort or function one is fine for PT MVP.".
@JerPearson JerPearson added Student Student Features User Story Business Items under Business Consideration labels Oct 23, 2024
@JerPearson JerPearson added this to the 3.0 Full-Time Students MVP milestone Oct 23, 2024
@CarlyCotton CarlyCotton changed the title Student: Family Information Tab Revisions Student: Sole custody dependant question change Oct 29, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 29, 2024
@andrewsignori-aot
Copy link
Collaborator

@Joshua-Lakusta @JerPearson regarding the below AC

 If possible please make it so that each individual dependant that has this exception selected has their own exception line on the ministry UI.

We saved a single expectation entry to the database, even if multiple are present.
My recommendation would be to execute the MVP version for this ticket unless we have a better idea about the Ministry's expected changes.

@Joshua-Lakusta
Copy link
Collaborator

@andrewsignori-aot We are happy to move forward with the MVP path and then create a separate ticket to address changes to this behavior down the road. Thank you for the clarity!

@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Nov 14, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
- Made these changes for the 25-26 program year application form
- Moved "Are any of the dependants listed above supported by you
financially but not under your sole custody?" question to the "Add
Dependants" box.
- Revised the question to: "Is the dependant listed above supported by
you financially but not under your sole custody?"
- Removed the key "Clean value when hidden" (`"clearOnHide": false`) for
file components `pdDependentUpload` and `dependantCustodyFileUpload` to
retain file data in the data column in each application record.
- Hooked the file component `pdDependentUpload` to `declaredOnTaxes`
condition.
- This question is included for each individual dependant added.
- Made sure that each individual dependant that has this exception
selected has their own exception line on the ministry UI.
- Applied changes to FT/PT

#### Note
Please note that the key `supportnocustodyDependants` is being used in
[Data Inventory Report SQL
script](https://github.com/bcgov/SIMS/blob/abd72bc8f549d387e0916ad14796e70e9d846ab0/sources/packages/backend/apps/db-migrations/src/sql/Reports/Create-data-inventory-report.sql#L179C37-L179C63).
The current approach moves the key `supportnocustodyDependants` from
`applications.data` to `applications.dependants` for applications
**2025-2026 only**, so the Data Inventory Report CSV file will lose the
data for column "Has dependants without sole custody flag"
(`supportnocustodyDependants`) for applications 2025-2026. To retain
this data, a simple workaround solution is available in the [workaround
commit](1444a25),
where the key `supportnocustodyDependants` is still accessible in
`applications.data` and its value is calculated based on whether any
dependant is without sole custody or not inside the dependants array. As
discussed in the standup, the workaround is not recommended, so it
mentioned here to as a reference to keep developers updated.

Screenshot on the student portal

![image](https://github.com/user-attachments/assets/db6a14cf-b504-43b6-8d97-849905c61f34)

Screenshot on the ministry portal

![image](https://github.com/user-attachments/assets/fa0988fc-4ad8-44ec-ba42-87e99db7e069)

Screenshot of the exception trigger when files are required

![image](https://github.com/user-attachments/assets/c170cf95-e918-4f4d-a7fd-680827e2a117)
@Joshua-Lakusta Joshua-Lakusta mentioned this issue Dec 17, 2024
3 tasks
@ninosamson
Copy link
Collaborator

removed estimate and linked to #4132, which should resolve this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Student Student Features User Story
Projects
None yet
Development

No branches or pull requests

6 participants