-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Student: Sole custody dependant question change #3827
Comments
@Joshua-Lakusta @JerPearson regarding the below AC
We saved a single expectation entry to the database, even if multiple are present. |
@andrewsignori-aot We are happy to move forward with the MVP path and then create a separate ticket to address changes to this behavior down the road. Thank you for the clarity! |
- Made these changes for the 25-26 program year application form - Moved "Are any of the dependants listed above supported by you financially but not under your sole custody?" question to the "Add Dependants" box. - Revised the question to: "Is the dependant listed above supported by you financially but not under your sole custody?" - Removed the key "Clean value when hidden" (`"clearOnHide": false`) for file components `pdDependentUpload` and `dependantCustodyFileUpload` to retain file data in the data column in each application record. - Hooked the file component `pdDependentUpload` to `declaredOnTaxes` condition. - This question is included for each individual dependant added. - Made sure that each individual dependant that has this exception selected has their own exception line on the ministry UI. - Applied changes to FT/PT #### Note Please note that the key `supportnocustodyDependants` is being used in [Data Inventory Report SQL script](https://github.com/bcgov/SIMS/blob/abd72bc8f549d387e0916ad14796e70e9d846ab0/sources/packages/backend/apps/db-migrations/src/sql/Reports/Create-data-inventory-report.sql#L179C37-L179C63). The current approach moves the key `supportnocustodyDependants` from `applications.data` to `applications.dependants` for applications **2025-2026 only**, so the Data Inventory Report CSV file will lose the data for column "Has dependants without sole custody flag" (`supportnocustodyDependants`) for applications 2025-2026. To retain this data, a simple workaround solution is available in the [workaround commit](1444a25), where the key `supportnocustodyDependants` is still accessible in `applications.data` and its value is calculated based on whether any dependant is without sole custody or not inside the dependants array. As discussed in the standup, the workaround is not recommended, so it mentioned here to as a reference to keep developers updated. Screenshot on the student portal  Screenshot on the ministry portal  Screenshot of the exception trigger when files are required 
removed estimate and linked to #4132, which should resolve this ticket. |
On the family information tab move location of sole custody question to allow the question to be dependent specific.
Acceptance Criteria
Technical
The text was updated successfully, but these errors were encountered: