Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ministry portal: Add name to all assessment pages #3287

Closed
20 tasks done
JerPearson opened this issue May 15, 2024 · 2 comments
Closed
20 tasks done

Ministry portal: Add name to all assessment pages #3287

JerPearson opened this issue May 15, 2024 · 2 comments
Assignees
Labels
Enhancement New feature or request Ministry Ministry Features User Story

Comments

@JerPearson
Copy link
Collaborator

JerPearson commented May 15, 2024

As a Ministry user I need to see the students identifying information on the 'assessment page', 'view assessment' page, and 'notice of assessment' page.

Acceptance Criteria

  • The following information should be displayed across the top of the 'assessment page', 'view assessment' page, and 'notice of assessment' page:

Name:
Application number:
Institution:
Study dates:
Type:

  • If there is no offering attached (PIR/draft/etc), do NOT show any OFFERING data (study dates, intensity)
  • Please update all fields to the above content.
  • Mock up Lets use common phrasing #1 shows the 'view assessment' page and how the information should be formatted and displayed, with name added to the left of application #.
  • Mock up Add missing topics #2 shows the 'notice of assessment' and where the fields should be added
  • Mock up Add missing license #3 shows the 'assessment' page and where the information should be displayed
  • For draft applications, this would result in Student Name only (no offering data / no app number)

#1
image.png

#2
image.png

#3
image.png

Technical

  • Consider below technical items as suggestions. Deviations or better approaches can be checked with the Team and are welcomed.
  • Adapt the existing endpoint aest/application/:applicationId to return the header information.
    • Create a query string parameter to allow optionally loading the dynamic application data, e.g. aest/application/:applicationId?load-dynamic-data=false.
      • Do not process the generateApplicationFormData case load-dynamic-data=false. SQL query already has a parameter to optionally load the form data.
      • Keep the default controller behavior if the query string parameter is not present (load-dynamic-data=true).
      • Create a new DTO extending from ApplicationBaseAPIOutDTO and add the extra properties.
        • studentFullName: use the getUserFullName method.
        • applicationOfferingIntensity, if the offering is not present, hide it.
        • applicationStartDate, if the offering is not present, hide it.
        • applicationEndDate, if the offering is not present, hide it.
        • institutionName: institution name from the sims.applications.location_id. Get the institution name using the location ID. This would allow us to show the institution name even for PIR (the same is not desirable for offerings). If not present, hide it. User the institution operatingName (to be confirmed).
  • Create a new component in Vue to display the header. Suggested name: application-header-title.
    • Create the component inside the components/aest/students folder.
    • User the existing header-title-value to display the key/value pairs.
    • Component should receive the application ID as a property and use it to call the API and render the information using the header-title-value.
  • E2E Tests
    • Endpoint does not have E2E tests. Create the below E2E tests.
      • Should get the application information including its dynamic data when the load-dynamic-data parameter is true.
      • Should get the application information excluding its dynamic data when the load-dynamic-data parameter is false.
@JerPearson JerPearson added Enhancement New feature or request User Story labels May 15, 2024
@JerPearson JerPearson self-assigned this May 15, 2024
@JerPearson JerPearson added Business Items under Business Consideration labels May 15, 2024
@JerPearson JerPearson changed the title Ministry view assessment - Add name to view assessment page Ministry portal- Add name to view assessment page May 15, 2024
@JerPearson JerPearson changed the title Ministry portal- Add name to view assessment page Content: Ministry portal: Add name to view assessment page May 15, 2024
@michesmith michesmith added the Ministry Ministry Features label May 16, 2024
@michesmith michesmith added this to the 2.0 Part-Time Students MVP milestone May 16, 2024
@JerPearson JerPearson changed the title Content: Ministry portal: Add name to view assessment page Content: Ministry portal: Add name to all assessment pages Aug 23, 2024
@CarlyCotton CarlyCotton changed the title Content: Ministry portal: Add name to all assessment pages Ministry portal: Add name to all assessment pages Sep 3, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Sep 3, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Sep 13, 2024
@katrina-aot-git katrina-aot-git self-assigned this Sep 19, 2024
@CarlyCotton
Copy link
Collaborator

@katrina-aot-git Updated mockup #2 regarding the NOA placement. Significant changes are coming to the NOA page content within the page and the previous area circled will be updated then.

FYI @andrewsignori-aot @JerPearson

@CarlyCotton
Copy link
Collaborator

@katrina-aot-git Based on the comments in the PR channel, I've updated the AC re PIR expectations and added an AC re Draft expectations

FYI @andrewsignori-aot @dheepak-aot

github-merge-queue bot pushed a commit that referenced this issue Sep 25, 2024
<img width="1664" alt="Screenshot 2024-09-23 at 11 15 28 AM"
src="https://github.com/user-attachments/assets/85ee69ab-c03f-4b45-b0c0-5dc95e6ace74">
<img width="1673" alt="Screenshot 2024-09-23 at 11 15 38 AM"
src="https://github.com/user-attachments/assets/4ebf97f3-1788-40d0-9d0f-de1d2a607300">
<img width="1659" alt="Screenshot 2024-09-23 at 11 15 45 AM"
src="https://github.com/user-attachments/assets/bf7c5c1e-ae76-49c6-b4b0-825d8cf53ebd">
If there is no offering attached:
<img width="1656" alt="Screenshot 2024-09-23 at 11 15 15 AM"
src="https://github.com/user-attachments/assets/da8ae773-9c2b-4117-ae1e-f59e3bcdb7e9">
@sslaws sslaws closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Ministry Ministry Features User Story
Projects
None yet
Development

No branches or pull requests

7 participants