Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error generating SINF exception during Student Application submission #2323

Closed
2 tasks
andrewsignori-aot opened this issue Sep 20, 2023 · 0 comments
Closed
2 tasks
Assignees
Labels
Bug Something isn't working

Comments

@andrewsignori-aot
Copy link
Collaborator

andrewsignori-aot commented Sep 20, 2023

While submitting a Student Application with a temporary SIN and the SIN will expire before the offering end date, the system generates a SINF exception and the below message.

Private Zenhub Image

Currently, an error in the query will create an error every time that the temporary SIN restriction check happens.

The current code is dealing with the field as if it is an array when it is just an enum.

restriction: {
  notificationType: Not(
    ArrayContains([RestrictionNotificationType.NoEffect]),
  ),
},

Expected code:

where: {
  id: In(ids),
  restriction: {
    notificationType: Not(RestrictionNotificationType.NoEffect),
  },
},

Acceptance criteria

  • Apply the above-mentioned fix.
  • Ensure that a Student with a temporary SIN will generate the SINF restriction and the proper banner will be displayed, as shown in the above image.
@andrewsignori-aot andrewsignori-aot self-assigned this Sep 26, 2023
@andrewsignori-aot andrewsignori-aot added the Bug Something isn't working label Sep 26, 2023
andrewsignori-aot added a commit that referenced this issue Sep 26, 2023
Fixed the query used by createNotifications that was throwing an error
due to the incorrect object-query syntax.
This was impacting multiple restriction notifications such as:
- Add Provincial Restriction
- Temporary SIN
- Scholastic Standing
- Federal Restrictions

The application submission is now working as expected, validating and
generating the error message.
@michesmith michesmith added this to the 2.0 Part-Time Students MVP milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants