Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a common container for content in tab #1757

Closed
1 task
dheepak-aot opened this issue Feb 27, 2023 · 0 comments
Closed
1 task

Create a common container for content in tab #1757

dheepak-aot opened this issue Feb 27, 2023 · 0 comments
Assignees
@sh16011993
Labels
Task

Comments

@dheepak-aot
Copy link
Collaborator

dheepak-aot commented Feb 27, 2023 •
edited
Loading

Describe the task
Create a container (like FullPageContainer) with defined template for content in tab. Refer figma for the template.

Acceptance Criteria

  • Create a container for all the tab content to follow a common template
@sh16011993 sh16011993 self-assigned this Feb 28, 2023
sh16011993 added a commit that referenced this issue Mar 16, 2023
@sh16011993
#1757 - Created common container for the contents in tab
41b8f7e 
Created common container for the contents in tab. However, this does not include the styling changes.
sh16011993 added a commit that referenced this issue Mar 16, 2023
@sh16011993
#1757 - Included default slot for BodyHeaderContainer
930d773
sh16011993 added a commit that referenced this issue Mar 16, 2023
@sh16011993
#1757 - Made changes to the styling
622dc43
sh16011993 added a commit that referenced this issue Mar 20, 2023
@sh16011993
#1757 - Updated code with code review suggestions
f07e056
sh16011993 added a commit that referenced this issue Mar 20, 2023
@sh16011993
#1757 - Updated BodyHeader to use a positive margin for the subtitle
e71c969
sh16011993 added a commit that referenced this issue Mar 21, 2023
@sh16011993
#1757 - Updated FullPageContainer to remove extra padding and margin …
19894e8 
…for centeredTab layout
sh16011993 added a commit that referenced this issue Mar 21, 2023
@sh16011993
#1757 - Adjusted the code for better readability
4a93e69
sh16011993 added a commit that referenced this issue Mar 21, 2023
@sh16011993
#1757 - Create common container for content in tab (#1816)
6064f16 
* #1757 - Created common container for the contents in tab

Created common container for the contents in tab. However, this does not include the styling changes.

* #1757 - Included default slot for BodyHeaderContainer

* #1757 - Made changes to the styling

* Commiting Notes file

* #1757 - Updated code with code review suggestions

* #1757 - Updated BodyHeader to use a positive margin for the subtitle

* #1757 - Updated FullPageContainer to remove extra padding and margin for centeredTab layout

* #1757 - Adjusted the code for better readability

---------

Co-authored-by: Shekhar <[email protected]>
sh16011993 added a commit that referenced this issue Mar 23, 2023
@sh16011993
#1757 - Create common container for content in tab (Institution) - Pa…
4a21d95 
…rt 2 (#1826)

* Updated the Institution tabs in the Ministry portal to use the common TabContainer and the BodyHeaderContainer

* Code updated with review comments
guru-aot pushed a commit that referenced this issue Mar 28, 2023
@sh16011993 @guru-aot
#1757 - Create common container for content in tab (Institution) - Pa…
cb2bdc5 
…rt 2 (#1826)

* Updated the Institution tabs in the Ministry portal to use the common TabContainer and the BodyHeaderContainer

* Code updated with review comments
guru-aot pushed a commit that referenced this issue Mar 28, 2023
@sh16011993 @guru-aot
#1757 - Create common container for content in tab (Institution) - Pa…
3343116 
…rt 2 (#1826)

* Updated the Institution tabs in the Ministry portal to use the common TabContainer and the BodyHeaderContainer

* Code updated with review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh16011993 sh16011993

Labels
Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sh16011993 @dheepak-aot @JasonCTang