NRPT 361 amalgamation of NRPTI issuing agency values #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NRPT-361 fixing all records add/edit and detail display NRPT 361 display name changes for BCMI NRPT 361 Updating LNG site instances NRPT-361 changes to NRCED and cleanup
cameronpettit
requested review from
danieltruong,
marklise,
MaxWardle,
BcGovNeal and
mtCarto
marklise
approved these changes
Jul 15, 2021
BcGovNeal
suggested changes
Jul 20, 2021
There was a problem hiding this comment.
I think the values in the collection agency picklist should be updated to be consistent with records. Will also need to include migrations for the collections.
https://github.com/cameronpettit/NRPTI/blob/239b42696a9fd9741bdf4820be1dd1d9b0fca1b2/angular/projects/common/src/app/utils/record-constants.ts#L269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a pervasive bug to fix -
issuingAgencyvalues in the db have been amalgamated such that there is one entry per agency. The search filters currently implemented do not allow searching for agency names with commas in them - they are parsed at the commas into individual queries, so the db agency names do not contain commas.The codebase has been combed and a wrapper function is used everywhere the issuing agency is displayed. There are two wrapper functions: One to display the full agency name (with commas) and the other to display the agency acronym, the latter being used for BCMI and the former everywhere else.
There is a migration to update the existing db entries and the importers & record add/edit pages have been updated to maintain 1 name per agency.