Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRPT-707: Adding emli integration. #842

Merged
merged 6 commits into from
May 5, 2021
Merged

NRPT-707: Adding emli integration. #842

merged 6 commits into from
May 5, 2021

Conversation

marklise
Copy link
Contributor

@marklise marklise commented Apr 30, 2021

Needs new ENV var: NRIS_EMLI_API_ENDPOINT to point to emprInspections (defaults to prod api @ https://api.nrs.gov.bc.ca/nrisws-api/v1/emprInspections)

Copy link
Contributor

@BcGovNeal BcGovNeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the issuing agency value, it looks good. Might need to address the Sonar scan results

api/src/integrations/nris-emli/datasource.js Outdated Show resolved Hide resolved
@marklise marklise requested a review from danieltruong May 5, 2021 18:14
api/src/integrations/nris-emli/datasource.js Outdated Show resolved Hide resolved
api/src/integrations/nris-emli/datasource.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marklise marklise merged commit f06e02a into bcgov:master May 5, 2021
@norrisng-bc norrisng-bc mentioned this pull request Aug 6, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants