Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRPT-712 public get controllers now determine target subset based on schemaName #829

Merged
merged 3 commits into from
Apr 15, 2021
Merged

NRPT-712 public get controllers now determine target subset based on schemaName #829

merged 3 commits into from
Apr 15, 2021

Conversation

cameronpettit
Copy link
Contributor

No description provided.

mtCarto
mtCarto reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@mtCarto mtCarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search controller looks good, the redactedSubset is still getting populated with the schemas listed in the skip set. Is the intention to keep them out of the subset altogether?

@cameronpettit
Copy link
Contributor Author

I kind of assumed that whether or not we would be populating redactedrSubset would be addressed in Max's accompanying ticket, but I haven't discussed that with him yet. https://bcmines.atlassian.net/browse/NRPT-711?atlOrigin=eyJpIjoiZTUxNDBmMTM3Nzg4NDMwMzgzN2Q5YjgyNjAyM2MwNDQiLCJwIjoiaiJ9

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cameronpettit cameronpettit merged commit 1d741ca into bcgov:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BcGovNeal BcGovNeal BcGovNeal approved these changes

@mtCarto mtCarto mtCarto approved these changes

@MaxWardle MaxWardle Awaiting requested review from MaxWardle

@danieltruong danieltruong Awaiting requested review from danieltruong

@marklise marklise Awaiting requested review from marklise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronpettit @mtCarto @BcGovNeal