NOBUG: removed publicGet and protectedGet from map-info-controller #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltruong
approved these changes
Apr 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
marklise
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
map-info-controller,publicGetandprotectedGetwere hardwired to afindByIdfunction that, if provided with the_id, of any record, returned that record regardless of user role, record redaction or token authentication. Though it would be difficult for someone to obtain the_idof a sensitive record, they would be able to access that record easily if they hit these endpoints.publicGetandprotectedGetare yet unused by any services in this project, so this PR removes them frommap-info-controllerand the swagger routes.