Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRPT-738 Add AMS Order CSV Import #825

Merged
merged 5 commits into from
Apr 13, 2021
Merged

NRPT-738 Add AMS Order CSV Import #825

merged 5 commits into from
Apr 13, 2021

Conversation

BcGovNeal
Copy link
Contributor

https://bcmines.atlassian.net/browse/NRPT-738

This PR also includes migration to remove duplicate AMS Orders from the ocers-csv source

@BcGovNeal BcGovNeal requested a review from MaxWardle April 8, 2021 16:07
MaxWardle
MaxWardle approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@MaxWardle MaxWardle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, double checked the entries in the records in the db. 👏

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BcGovNeal BcGovNeal merged commit 5caa686 into bcgov:master Apr 13, 2021
@BcGovNeal BcGovNeal deleted the NRPT-738 branch May 5, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxWardle MaxWardle MaxWardle approved these changes

@mtCarto mtCarto mtCarto approved these changes

@marklise marklise Awaiting requested review from marklise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BcGovNeal @mtCarto @MaxWardle