-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRPT-407: migration to add issuing agency and role to historical NRCED records #811
Conversation
api/migrations/20210316214525-addIssuingAgencyAndRoleToHistoricalNRCED.js
Outdated
Show resolved
Hide resolved
api/migrations/20210316214525-addIssuingAgencyAndRoleToHistoricalNRCED.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just couple minor (and obscure) issues left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MIgration looks good, address the string changes suggested by Neal and this is good to go
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.