Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRPT-407: migration to add issuing agency and role to historical NRCED records #811

Merged
merged 8 commits into from
Mar 26, 2021

Conversation

cameronpettit
Copy link
Contributor

No description provided.

Copy link
Contributor

@BcGovNeal BcGovNeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just couple minor (and obscure) issues left.

api/src/utils/constants/misc.js Outdated Show resolved Hide resolved
api/src/utils/constants/misc.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mtCarto mtCarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIgration looks good, address the string changes suggested by Neal and this is good to go

@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cameronpettit cameronpettit merged commit a089f7e into bcgov:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants