Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRPT-666: LNG minimap added #786

Merged
merged 4 commits into from
Feb 25, 2021
Merged

NRPT-666: LNG minimap added #786

merged 4 commits into from
Feb 25, 2021

Conversation

cameronpettit
Copy link
Contributor

No description provided.

mtCarto
mtCarto approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@mtCarto mtCarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini-map looks great, everything is working as expected. Only improvemnt would be the one UX issue you mentioned in the ticket, to hide the vector layers while flying.

marklise
marklise approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@marklise marklise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, land when tests pass

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cameronpettit cameronpettit merged commit 18abcdf into bcgov:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtCarto mtCarto mtCarto approved these changes

@marklise marklise marklise approved these changes

@MaxWardle MaxWardle Awaiting requested review from MaxWardle

@danieltruong danieltruong Awaiting requested review from danieltruong

@BcGovNeal BcGovNeal Awaiting requested review from BcGovNeal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronpettit @marklise @mtCarto