NRPT-262: Associating mine records. Fixing unit tests, code cleanup. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitArmstrong
approved these changes
Aug 14, 2020
|
Not sure if this is a problem:
|
danieltruong
approved these changes
Aug 14, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
mtCarto
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of this bug was to add associated mine records. This changes how the project and mine selectors work by assigning the dropdown value to either form element as long as the record is an
nrptisource.There is now a service that pulls the epic project list and mine list from the back-end on an interval and stuffs it into the storage service. The storage service emits this so that we can subscribe to the change and update the UI without requiring a page load.
The task expanded into discovering a slew of issues w.r.t tests and discovering race conditions in running them, and just finding and fixing a whole lot of things. I found sometimes they would fail, and sometimes they would pass. Usually the first run would pass, and the second run would fail (and then alternate pass/fail/pass/fail). I could split them out but there are so many changes and most are originating from a bad initial copy-paste that got replicated all over the place.
The unit tests we have mostly only bootstrap the test, but in fixing and cleaning them up this should save time for others in making them actually useful.