Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRPT-57: Allows multiple NRIS imports #537

Merged
merged 3 commits into from
Aug 12, 2020

Conversation

KitArmstrong
Copy link
Contributor

Ticket: https://bcmines.atlassian.net/browse/NRPT-57

Stops duplication when the NRIS importer is run more than once. Also includes a migration to add the source reference ID for the NRIS records as there was an issue that was saving them as null.

documentName: { type: String, defualt: '' },
documentId: { type: 'ObjectId', default: null }
},
documents: [{ type: 'ObjectId', default: [], index: true }],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to match the master.

Copy link
Contributor

@dhlevi dhlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, migrations do as expected, import appears to do as requested with the findExistingRecord check

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KitArmstrong KitArmstrong merged commit f9f3645 into bcgov:master Aug 12, 2020
@KitArmstrong KitArmstrong deleted the updateNprtiImporter branch August 12, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants