Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOBUG: Mine Record Detail Update #528

Merged
merged 2 commits into from
Aug 5, 2020
Merged

NOBUG: Mine Record Detail Update #528

merged 2 commits into from
Aug 5, 2020

Conversation

KitArmstrong
Copy link
Contributor

Truncates long mine record names and adds the date issued as a display field.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
28.8% 28.8% Duplication

dhlevi
dhlevi approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@dhlevi dhlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@KitArmstrong KitArmstrong merged commit c049064 into bcgov:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhlevi dhlevi dhlevi approved these changes

@danieltruong danieltruong danieltruong approved these changes

@marklise marklise Awaiting requested review from marklise

@MaxWardle MaxWardle Awaiting requested review from MaxWardle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KitArmstrong @danieltruong @dhlevi