NRPT-214: New Record Types #521
Conversation
dhlevi
requested review from
marklise,
mtCarto,
MaxWardle,
danieltruong and
KitArmstrong
| this.lastEditedSubText = `Added on ${this.utils.convertJSDateToString(new Date(this.currentRecord.dateAdded))}`; | ||
| } | ||
| for (const flavour of this.currentRecord.flavours) { | ||
| switch (flavour._schemaName) { |
There was a problem hiding this comment.
Nit: maybe just an if in this case?
| } | ||
|
|
||
| navigateToDetails() { | ||
| this.router.navigate(['records', 'annual-reports', this.currentRecord._id, 'detail']); |
There was a problem hiding this comment.
Without the / in front of records this will navigate relative the route it is called from. Is that intended? Depending on where this screen is it might work as expected without the / too.
There was a problem hiding this comment.
For the routers here I just copied it exactly from the other details/add-edit screens. Happy to make a change, but if so I should make the change to all of them, not just the five new ones... they all seem to work as expected for now though!
|
|
||
| if (!this.isEditing) { | ||
| this.factoryService.createAnnualReport(annualReport).subscribe(async res => { | ||
| console.log(res); |
| this.factoryService | ||
| ); | ||
|
|
||
| console.log(docResponse); |
| .pipe( | ||
| takeUntil(this.ngUnsubscribe), | ||
| catchError(error => { | ||
| console.log('Publish error:', error); |
There was a problem hiding this comment.
Should we log the error?
|
|
||
| if (!this.isEditing) { | ||
| this.factoryService.createCertificateAmendment(certificateAmendment).subscribe(async res => { | ||
| console.log(res); |
| this.factoryService | ||
| ); | ||
|
|
||
| console.log(docResponse); |
| this.factoryService | ||
| ); | ||
|
|
||
| console.log(docResponse); |
|
|
||
| if (!this.isEditing) { | ||
| this.factoryService.createCorrespondence(correspondence).subscribe(async res => { | ||
| console.log(res); |
Fixed the log statements and other notes above. Checked all of the new pages and updated where appropriate across the board. Early on in development, I thought it would be a much nicer idea to convert a lot of the duplicate flavour stuff, record screens and functions scattered in various other components (the huge case statements, ex.) into more generic common components. It's starting to get fairly unruly in some spots and much of it would be easy enough to convert to single functions with a type. Not the time to do it with this ticket, but it might be worth a technical debt ticket to see about updating a lot of this stuff into shared/common functions and components. |
| this.factoryService | ||
| ); | ||
|
|
||
| console.log(docResponse); |
There was a problem hiding this comment.
remove or use a logging util?
| .pipe( | ||
| takeUntil(this.ngUnsubscribe), | ||
| catchError(error => { | ||
| console.log('Unpublish error:', error); |
| .pipe( | ||
| takeUntil(this.ngUnsubscribe), | ||
| catchError(error => { | ||
| console.log('Publish error:', error); |
| .pipe( | ||
| takeUntil(this.ngUnsubscribe), | ||
| catchError(error => { | ||
| console.log('Unpublish error:', error); |
| this.factoryService | ||
| ); | ||
|
|
||
| console.log(docResponse); |
| .pipe( | ||
| takeUntil(this.ngUnsubscribe), | ||
| catchError(error => { | ||
| console.log('Publish error:', error); |
| .pipe( | ||
| takeUntil(this.ngUnsubscribe), | ||
| catchError(error => { | ||
| console.log('Unpublish error:', error); |
| const outboundObject = { | ||
| correspondences: [correspondence] | ||
| }; | ||
| console.log(outboundObject); |
| const outboundObject = { | ||
| annualReports: [report] | ||
| }; | ||
| console.log(outboundObject); |
| const outboundObject = { | ||
| damSafetyInspections: [damSafetyInspection] | ||
| }; | ||
| console.log(outboundObject); |
|
Extra console logging removed |
Adding new record types for NRPTI:
includes API, common, and UI components.
All record types contain the mineGuid ref, but currently there's no way to set this via the screens and it is not part of the existing ticket spec. We'll have to include a method of associating the guid for manual creation of these and other record types for use in BCMI.
There's a lot of code to look over and I'm sure I've missed a few spots or made mistakes, so I'm pinging everyone to have a look!
See tickets NRPT-214 (the UI) and NRPT-284 (The API)