Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new role "Technical Support - LJ" (API, User management for LG) #831

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

Add new role "Technical Support - LJ" (API, User management for LG) #831

wants to merge 44 commits into from

Conversation

guri-dev
Copy link
Contributor

@guri-dev guri-dev commented Dec 13, 2024 •
edited
Loading

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📦 Chore (Release)
  • ✅ Test

Related Tickets & Documents

Steps to QA

UI Accessibility Checklist

Note the following checklist is not an exhaustive list. Check
the WebAIM checklist for
a user-friendly checklist with more details. Aim to meet at least AA conformance level where applicable. Check
the WCAG guidelines for the full guidelines.

  • Markup uses semantic HTML?
  • Additional context added through aria-roles and aria-labels?
  • Checked
    with Wave Browser Extension
    for accessibility errors?
  • Usable with a keyboard and navigable in a logical order?
  • Usable using a screen reader (e.g. Voiceover for Mac) with enough context for the user?

General Checklist

  • ✅ Provide tests for your changes where relevant
  • 📝 Use descriptive commit messages
  • 📗 Update any related documentation and include any relevant screenshots
  • 📱 For UI-related tasks, ensure responsive design is implemented across multiple screen size
  • 🗂️ Move your relevant story/task to the Ready for Code Review state

[optional] Are there any post-deployment tasks we need to perform?

bkmaibach
bkmaibach requested changes Dec 13, 2024
View reviewed changes
app/frontend/i18n/i18n.ts Outdated Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
@guri-dev guri-dev force-pushed the BPHH-1519-create-new-role-technical-support-lj-api-user-management-for-lg branch from 9d22e81 to 967dcd3 Compare December 13, 2024 22:19
@guri-dev guri-dev changed the title Working on creating a new user role Create new role "Technical Support - LJ" (API, User management for LG) Dec 13, 2024
@guri-dev guri-dev changed the title Create new role "Technical Support - LJ" (API, User management for LG) Add new role "Technical Support - LJ" (API, User management for LG) Dec 13, 2024
@guri-dev guri-dev marked this pull request as ready for review December 13, 2024 22:36
bkmaibach
bkmaibach requested changes Dec 17, 2024
View reviewed changes
app/models/user.rb Outdated Show resolved Hide resolved
app/frontend/types/enums.ts Show resolved Hide resolved
@guri-dev guri-dev requested a review from smithskye January 3, 2025 22:38
derekyau and others added 24 commits January 3, 2025 14:51
@derekyau
Refactor omniauth_uid and omniauth_username to use case statements ex…
e02cfc1 
…plicitly
show better eula error message
f816376
add data migration for enabling appropriate inboxes
556f6b3
bugfixes for block copy, jurisdiction select, rm select, disable noti…
ae291e0 
…fications
fix landing, copy, jurisdiction minimal blueprint
d2ab96f
remove sandbox specific labeling for api key setup
a1bf166
@derekyau
Remove limits for Dev / Test environments as per Openshift new policies
ab73158
@derekyau
Adjust parameters for production (removal of limits and add more node…
758a285 
…s for Redis and ES)
move users to jurisdicton config management
fcd603f
@derekyau
automatically detect SHA and add that to the VITE_RELEASE_VERSION ENV…
4a607bd 
… var for dev and test
@derekyau
Use slice instead
9f5acea
@derekyau
use full SHA
2ac60f1
@derekyau
minor changes to nav styling for the SHA, etc.
16ab96b
show single column grid for login on mobile
79def2f
@dependabot
Bump rails-html-sanitizer from 1.6.0 to 1.6.1
ef6abfd 
Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/rails/rails-html-sanitizer/releases)
- [Changelog](https://github.com/rails/rails-html-sanitizer/blob/main/CHANGELOG.md)
- [Commits](rails/rails-html-sanitizer@v1.6.0...v1.6.1)

---
updated-dependencies:
- dependency-name: rails-html-sanitizer
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
bump vite to latest
e2342d2
update rollup and peer deps
d4b2176
update rails and thus actionpack to 7.1.5.1
ec73eff
@derekyau
Fixes and optimizes the Docker build after the various updates
ecf8b67
@derekyau
Add VITE_BSCS_REGISTRATION_URL to Dockerfile
5501aed
@derekyau
Adjust prod values for more resiliency in Redis and ES
4915593
@derekyau
Add BCSC_REGISTRATION_URL to dev.yml
b245e12
@derekyau
Add to the other environments as well
f533295
Created a new method to handle jurisdiciton staff role to be used in …
2f5ba84 
…future user role references
smithskye
smithskye approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@smithskye smithskye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, What I am able to for this role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkmaibach bkmaibach bkmaibach requested changes

@smithskye smithskye smithskye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guri-dev @bkmaibach @smithskye @derekyau