-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Divider
component
#88
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 87.76% 87.91% +0.15%
==========================================
Files 76 78 +2
Lines 1267 1283 +16
Branches 197 197
==========================================
+ Hits 1112 1128 +16
Misses 126 126
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Requested one change about the conditional rendering of children.
flexItem={flexItem} | ||
textAlign={textAlign} | ||
> | ||
<Children nodes={nodes} onChange={onChange} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the nodes are never undefined, because we send an empty array instead, a gap appears in the divider which is not an expected behaviour. The children code can be modified as below
<Children nodes={nodes} onChange={onChange} /> | |
{nodes && nodes.length && <Children nodes={nodes} onChange={onChange} />} |
Addresses #41