Skip to content

fix(core): subtract container bounds when getting pointer position #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcakmakoglu merged 3 commits into from
Apr 23, 2025
Merged

fix(core): subtract container bounds when getting pointer position #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fd8197
fix(core): subtract container bounds when getting pointer position
bcakmakoglu Apr 23, 2025
3734718
chore(changeset): add
bcakmakoglu Apr 23, 2025
a4173b8
chore: cleanup
bcakmakoglu Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-jokes-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vue-flow/core": patch
---

Subtract container bounds when calculating pointer position.
7 changes: 4 additions & 3 deletions packages/core/src/composables/useGetPointerPosition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,18 @@ import type { UseDragEvent } from './useDrag'
* @internal
*/
export function useGetPointerPosition() {
const { viewport, snapGrid, snapToGrid } = useVueFlow()
const { viewport, snapGrid, snapToGrid, vueFlowRef } = useVueFlow()

// returns the pointer position projected to the VF coordinate system
return (event: UseDragEvent | MouseTouchEvent) => {
const containerBounds = vueFlowRef.value?.getBoundingClientRect() ?? { left: 0, top: 0 }
const evt = isUseDragEvent(event) ? event.sourceEvent : event

const { x, y } = getEventPosition(evt)
const { x, y } = getEventPosition(evt, containerBounds as DOMRect)
const pointerPos = pointToRendererPoint({ x, y }, viewport.value)
const { x: xSnapped, y: ySnapped } = snapToGrid.value ? snapPosition(pointerPos, snapGrid.value) : pointerPos

// we need the snapped position in order to be able to skip unnecessary drag events
// we need the snapped position to be able to skip unnecessary drag events
return {
xSnapped,
ySnapped,
Expand Down
Loading