Merge pull request #849 from marcotc/excon-warning

Suppress excon warning generated by extra key
bblimke · Sep 17, 2019 · 8bca1c4 · 8bca1c4
2 parents 97ed7a8 + 97d135c
commit 8bca1c4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/webmock/http_lib_adapters/excon_adapter.rb b/lib/webmock/http_lib_adapters/excon_adapter.rb
@@ -159,4 +159,7 @@ def self.new(args = {})
       end
     end
   end
+
+  # Suppresses Excon connection argument validation warning
+  Excon::VALID_CONNECTION_KEYS << :__construction_args
 end
diff --git a/spec/acceptance/excon/excon_spec_helper.rb b/spec/acceptance/excon/excon_spec_helper.rb
@@ -28,6 +28,8 @@ def http_request(method, uri, options = {}, &block)
       res
     end
 
+    Excon.set_raise_on_warnings!(true)
+
     OpenStruct.new \
       body: response.body,
       headers: headers,
-Original file line number
+Diff line change
@@ Expand Up / @@ -159,4 +159,7 @@ def self.new(args = {}) @@
           end
         end
       end
+      # Suppresses Excon connection argument validation warning
+      Excon::VALID_CONNECTION_KEYS << :__construction_args
     end