Semantic #38

juanjux · 2018-08-04T18:34:10Z

Ready to merge.

Signed-off-by: Juanjo Alvarez <[email protected]>

dennwc

Have some questions, plus the rename is needed.

dennwc · 2018-08-07T11:33:32Z

build.yml

+      - path: '/native/build/libs/native-jar-with-dependencies.jar'
+  test:
+    run:
+      # download and use gradle 4.9 since alpine's version is bugged for tests


Tests are running on top of openjdk:8-slim, according to the config

Interesting. Why are they using that if it's the image specificed for "build" that is at the same level as "test"? Adding an image: 'openjdk:8-jre-alpine' inside test will fix it?

This comment is still not addressed. It tells that "gradle from alpine is broken", but an image that runs tests is not Alpine, it's Debian. Are you sure you still need to download manually grade instead of using a version provided by Debian, or by some PPA?

Ahh, ok, I misunderstood your comment as saying that I shouldn't run that base image for the tests. I'll take a look at this.

PR updated.

dennwc · 2018-08-07T11:34:33Z

build.yml

+      - path: src/main/sh/native.sh
+        dest: native
+  deps:
+      - 'apk add gradle'


Is it a dependency for running the driver? Why?

Vestigial, fixed on next commit.

dennwc · 2018-08-07T11:35:03Z

driver/fixtures/fixtures_test.go

+
+var Suite = &fixtures.Suite{
+	Lang: "bash",
+	Ext:  ".bash",


I prefer .bash for the fixtures since sh could be understood as POSIX-sh and some tests use bash features.

dennwc · 2018-08-07T11:38:34Z

driver/normalizer/normalizer.go

+				},
+				Obj{
+					uast.KeyType: Var("_type2"),
+					"startOffset": Var("_startOffset2"),


Why is startOffset visible here? Preprocessor should take care of it.

Yeah. Randomly trying things at that point since no matter what I do that annotation doesn't match...

dennwc · 2018-08-07T11:39:06Z

driver/normalizer/normalizer.go

+					"Node": UASTType(uast.Function{}, Obj{
+						"Type": UASTType(uast.FunctionType{}, Obj{
+							//"Arguments": Var("args"),
+							"Arguments": nil,


Where is that IsNil() defined? I can't find it in the SDK.

Signed-off-by: Juanjo Alvarez <[email protected]>

dennwc · 2018-08-07T14:21:33Z

build.yml

+    artifacts:
+      - path: '/native/build/libs/native-jar-with-dependencies.jar'
+  test:
+    image: 'openjdk:8-jre-alpine'


I won't work. See FROM native as native_test line in the Dockerfile.

I don't understand why are you trying to test against Alpine version if your build environment is Debian Slim.

Because some comments above you noted on a line of the "test" section:

"Tests are running on top of openjdk:8-slim, according to the config"

You didnt answered my question as reply of that comment so I understood that I should have added it to the test section.

Signed-off-by: Juanjo Alvarez <[email protected]>

juanjux · 2018-08-09T09:17:06Z

@dennwc PR updated to remove the manual gradle download.

dennwc · 2018-08-09T09:22:32Z

native/Gopkg.toml

@@ -0,0 +1,30 @@
+# Gopkg.toml example


These files are probably unused (in native folder)

Signed-off-by: Juanjo Alvarez <[email protected]>

Juanjo Alvarez added 5 commits July 24, 2018 14:04

Several fixes and improvements to the native output

91b3b6d

Signed-off-by: Juanjo Alvarez <[email protected]>

Semantic object update plus other fixes

cf19195

Signed-off-by: Juanjo Alvarez <[email protected]>

Migrated to the new build system, removed [Bash] from internal_types

083ffad

Signed-off-by: Juanjo Alvarez <[email protected]>

changed go 1.10 to go 1.10-native

21646d5

Signed-off-by: Juanjo Alvarez <[email protected]>

Updated a test fixture

9e929f8

Signed-off-by: Juanjo Alvarez <[email protected]>

juanjux added the enhancement label Aug 4, 2018

juanjux self-assigned this Aug 4, 2018

juanjux requested a review from dennwc August 4, 2018 18:34

Juanjo Alvarez added 2 commits August 4, 2018 20:36

Updated to follow another SDK's modules and functions renames

60b1ccb

Signed-off-by: Juanjo Alvarez <[email protected]>

Fixed bblfsh-sdk test

74318eb

Signed-off-by: Juanjo Alvarez <[email protected]>

dennwc requested changes Aug 7, 2018

View reviewed changes

build.yml fixes from review

60a1db2

Signed-off-by: Juanjo Alvarez <[email protected]>

dennwc reviewed Aug 7, 2018

View reviewed changes

Fixed the function annotation

2404bf2

Signed-off-by: Juanjo Alvarez <[email protected]>

juanjux changed the title ~~[Do Not Merge] Semantic~~ Semantic Aug 8, 2018

Juanjo Alvarez added 3 commits August 8, 2018 11:21

Remove another meaningless node

9297589

Signed-off-by: Juanjo Alvarez <[email protected]>

Improve comments

8cc7bd0

Signed-off-by: Juanjo Alvarez <[email protected]>

Use debian's gradle for tests

69f4220

Signed-off-by: Juanjo Alvarez <[email protected]>

dennwc reviewed Aug 9, 2018

View reviewed changes

native/Gopkg.toml Outdated

@@ -0,0 +1,30 @@

# Gopkg.toml example

Copy link

Member

dennwc Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are probably unused (in native folder)

Remove espurious files

70e923c

Signed-off-by: Juanjo Alvarez <[email protected]>

dennwc approved these changes Aug 9, 2018

View reviewed changes

juanjux merged commit a9e5245 into bblfsh:master Aug 9, 2018

dennwc mentioned this pull request Aug 9, 2018

Update drivers to use new DSL (BIP-5) bblfsh/sdk#243

Closed

7 tasks

Semantic #38

Semantic #38

Uh oh!

Conversation

juanjux commented Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dennwc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juanjux Aug 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juanjux commented Aug 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

juanjux commented Aug 4, 2018 •

edited

Loading

juanjux Aug 7, 2018 •

edited

Loading