Skip to content

Conversation

texonidas
Copy link

Converted the project to TypeScript. Would love for you to give it a once-over, I have yet to actually test run this as a package as it's late where I am. Will hopefully get time to do some testing tomorrow.

@bberak
Copy link
Owner

bberak commented Jun 5, 2023

Thanks for the PR @texonidas

I'll do my best to review this sometime during the week.. Seems like a big change though -- would this have a big impact on developers using a simple development toolchain?

If anything, we might need to bump the major version before we publish this update.

@texonidas
Copy link
Author

texonidas commented Jun 6, 2023

So as far as I am aware, the compiled code should be usable regardless of the dev chain in use by the person consuming the package (I've never published a package before so may be incorrect there).

There were several babel-related dependencies that were throwing security warnings, so I thought updating everything to a more modern compilation experience would be useful. But as above, I believe the only people who need to concern themselves with contributing to this package itself who would need to worry about the toolchain of this project.

As far as testing goes, it should be possible to use npm link to make this into a local package and then try to import it into an existing project to see if anything explodes. The compiled TS code should match the existing codebase, as I didn't make any logic changes outside of null checks.

@bberak
Copy link
Owner

bberak commented Feb 25, 2024

Thanks @texonidas - and apologies for the late response 😬

I'll import your PR into one of my existing projects next weekend and see how it goes (I spent some time doing something similar for RNGE today). Cheers.

@lucasdellabella
Copy link

lucasdellabella commented Feb 26, 2024

Hey @bberak funny that you just responded to this - working on a project right now, and been considering integrating react-game-engine for a week or two with what we've been working on, and I'm seeing this issue now. I generally use exclusively typescript. I've heard typescript can be a headache for framework authors though.

There aren't types available on definitely typed, so I'd be excited if this project had some kind of TS support.

Subscribed to thread 👍🏼

@bberak
Copy link
Owner

bberak commented Feb 26, 2024

Hey @lucasdellabella,

Yeah people have been asking for this more and more; so I figured it's time to bite the bullet and either migrate to TS completely or at least add some type definitions.. Thankfully not starting from scratch thanks to PRs like this one 🙏. Aiming to move this forward next weekend 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants