Kip1071 trunk rebase 11 25 add bruno pr#3
Closed
bbejeck wants to merge 2 commits into
Closed
Conversation
A stream thread needs to integrate with the Streams membership manager to receive an assignment. This happens through callbacks that are set in the streams assignment interface. The Streams membership manager calls three callbacks: - onTasksRevoked that revokes tasks assigned to the stream thread - onTaskAssigned that assigns tasks to the stream thread - onAllTasksLost that releases all tasks of a stream thread and closes them dirty. Initially, we thought we could avoid onTasksRevoked by just considering revoked tasks in onTaskAssigned. However, it turns out we cannot avoid onTasksRevoked because if we do that we would need to set the new assignment in the subscription state before or after the call to onTaskAssigned. If we set the new assignment in the subscription state before we call onTaskAssigned, commits of the revoked tasks will fail because the subscription state would not contain the partitions of the revoked tasks anymore. If we set the new assignment in the subscription state after we call onTaskAssigned, we cannot safely pause the partitions of the assigned task for restoration because we do not know when the new assignment is actually set in the subscription state since that happens on the background thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)